Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Daily challenge statistics display does not have suffixes #29355

Closed
frenzibyte opened this issue Aug 8, 2024 · 3 comments
Closed

Daily challenge statistics display does not have suffixes #29355

frenzibyte opened this issue Aug 8, 2024 · 3 comments
Assignees
@frenzibyte
Labels
area:overlay-user-profile type:cosmetic type:localisation

Comments

@frenzibyte
Copy link
Member

image

The localisation strings ShowDailyChallengeUnitDay and ShowDailyChallengeUnitWeek appear to not have the suffixes added to them. cc @smoogipoo
@smoogipoo
Copy link
Contributor

It's impossible for this to be handled with the way localisations currently work. We'll need to define osu!-specific localisation strings or use Humanizer instead.

@peppy
Copy link
Member

peppy commented Aug 9, 2024

just implement locally without localisations.

@frenzibyte frenzibyte self-assigned this Aug 13, 2024
@frenzibyte frenzibyte mentioned this issue Aug 13, 2024
Closed
@frenzibyte
Copy link
Member Author

Resolved in #29414

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frenzibyte frenzibyte

Labels
area:overlay-user-profile type:cosmetic type:localisation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix daily challenge stats display suffix not displayed frenzibyte/osu
3 participants
@peppy @smoogipoo @frenzibyte