Remove confirmation when game is asked to be restarted by the user #26558
Conversation
| { | ||
| game.AttemptExit(); | ||
| } | ||
| else |
There was a problem hiding this comment.
The flow here makes me wonder whether Restart should handle the confirmation for platforms which can't restart themselves, rather than having this handled on each usage.
But then again, the usages may be so few and far between that it's fine to leave it as-is?
There was a problem hiding this comment.
I'd say per-usage is better because places like tournament client use Restart() and I don't really wanna think about how to make that work well across such varied usages.
peppy
force-pushed
the
restart-confirmation-bypass
branch
from
fbd1b84 to
3649876
Compare
|
I guess bump to @ppy/team-client on this one, I think it's still good to go ahead if the direction of using |
| @@ -125,7 +126,10 @@ public override bool RestartAppWhenExited() | |||
| return true; | |||
| } | |||
|
|
|||
| return base.RestartAppWhenExited(); | |||
| SessionStatics.SetValue(Static.RestartRequested, true); | |||
| AttemptExit(); | |||
There was a problem hiding this comment.
This is never reached in Windows because of the early return above.
There was a problem hiding this comment.
This seems valid to me, it looks like the game would not actually exit itself.
| game.AttemptExit(); | ||
| } | ||
| else | ||
| if (game?.Restart() != true) |
There was a problem hiding this comment.
If I thinking this right, on Windows, changing the renderer will just outright restart. Would still expect a confirmation dialog here, but different wording that it will restart automatically.
There was a problem hiding this comment.
Don't really think its necessary.
|
The |
| { | ||
| SessionStatics.SetValue(Static.RestartRequested, true); |
There was a problem hiding this comment.
This is never set back to false if the user cancels the dialog on unsupported platforms.
With hold-to-confirm delay set to 0:
Kapture.2024-04-17.at.13.41.08.mp4
Opening this as a draft to figure out direction with this. Arguably
SessionStaticsis not the correct place for the flag, and it should live inOsuGame. I'd keep it in the parameters alone but it's hard to get the message toMainMenuas part of theOnExitingflow.Will add tests once a direction is agreed upon.
This is low priority.
All game restart requests are triggered via user intent, so they shouldn't require confirmation.
Addresses #25826 (reply in thread).