Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hexgrid and circular grid to the osu editor #26310

Merged
merged 12 commits into from
Jul 3, 2024

Merge branch 'master' into grids-2

17ce9cd
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Add hexgrid and circular grid to the osu editor #26310

Merge branch 'master' into grids-2
17ce9cd
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Results (macOS, SingleThread) failed Jul 3, 2024 in 0s

5908 passed, 2 failed and 52 skipped

Tests failed

❌ TestResults-macOS-SingleThread.trx

5962 tests were completed in 1645s with 5908 passed, 2 failed and 52 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Tests.Visual.Gameplay.TestSceneLeadIn 16✅ 1❌ 4s
osu.Game.Tests.Visual.Ranking.TestSceneResultsScreen 20✅ 1❌ 19s

❌ osu.Game.Tests.Visual.Gameplay.TestSceneLeadIn

✅ TestConstructor
✅ TestLeadInProducesCorrectStartTime(1000,0)
✅ TestLeadInProducesCorrectStartTime(10000,-7830.0d)
✅ TestLeadInProducesCorrectStartTime(2000,0)
✅ TestLeadInProducesCorrectStartTime(3000,-830.0d)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-1000,-1000,False)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-1000,-1000,True)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-10000,-10000,False)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-10000,-10000,True)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(0,0,False)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(0,0,True)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(1000,0,False)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(1000,0,True)
❌ TestStoryboardProducesCorrectStartTimeSimpleAlpha(-1000,-1000)
	check first frame time: Expected: -1000.0d +/- 100.0d
	  But was:  -557.98208399999999d
	  Off by:   -442.01791600000001d
	
✅ TestStoryboardProducesCorrectStartTimeSimpleAlpha(-10000,-10000)
✅ TestStoryboardProducesCorrectStartTimeSimpleAlpha(0,0)
✅ TestStoryboardProducesCorrectStartTimeSimpleAlpha(1000,0)

❌ osu.Game.Tests.Visual.Ranking.TestSceneResultsScreen

✅ TestConstructor
✅ TestDownloadButtonInitiallyDisabled
✅ TestFetchScoresAfterShowingStatistics
✅ TestResultsForUnranked
✅ TestResultsWithFailingRank
❌ TestResultsWithFailingRankOnLegacySkin
	"expanded panel in centre of screen" timed out
✅ TestResultsWithoutPlayer
✅ TestResultsWithPlayer(0.2d,D,51)
✅ TestResultsWithPlayer(0.5d,D,21)
✅ TestResultsWithPlayer(0.75d,C,11)
✅ TestResultsWithPlayer(0.85d,B,9)
✅ TestResultsWithPlayer(0.925d,A,5)
✅ TestResultsWithPlayer(0.975d,A,1)
✅ TestResultsWithPlayer(0.975d,S,0)
✅ TestResultsWithPlayer(0.9999d,S,0)
✅ TestResultsWithPlayer(1,X,0)
✅ TestRulesetWithNoPerformanceCalculator
✅ TestScaling
✅ TestShowHideStatistics
✅ TestShowHideStatisticsViaOutsideClick
✅ TestShowStatisticsAndClickOtherPanel

Annotations

Check failure on line 0 in TestResults-macOS-SingleThread.trx

See this annotation in the file changed.

@github-actions github-actions / Test Results (macOS, SingleThread)

osu.Game.Tests.Visual.Gameplay.TestSceneLeadIn ► TestStoryboardProducesCorrectStartTimeSimpleAlpha(-1000,-1000)

Failed test found in:
  TestResults-macOS-SingleThread.trx
Error:
  check first frame time: Expected: -1000.0d +/- 100.0d
    But was:  -557.98208399999999d
    Off by:   -442.01791600000001d
  
Raw output
check first frame time: Expected: -1000.0d +/- 100.0d
  But was:  -557.98208399999999d
  Off by:   -442.01791600000001d

   at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
   at osu.Framework.Threading.Scheduler.Update()
   at osu.Framework.Graphics.Drawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Platform.GameHost.UpdateFrame()
   at osu.Framework.Threading.GameThread.processFrame()
   at osu.Framework.Platform.ThreadRunner.RunMainLoop()
   at osu.Framework.Platform.GameHost.windowUpdate()
   at osu.Framework.Platform.GameHost.Run(Game game)

Check failure on line 539 in osu.Game/Tests/Visual/OsuTestScene.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (macOS, SingleThread)

osu.Game.Tests.Visual.Ranking.TestSceneResultsScreen ► TestResultsWithFailingRankOnLegacySkin

Failed test found in:
  TestResults-macOS-SingleThread.trx
Error:
  "expanded panel in centre of screen" timed out
Raw output
"expanded panel in centre of screen" timed out
   at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in /Users/runner/work/osu/osu/osu.Game/Tests/Visual/OsuTestScene.cs:line 539
   at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
   at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)