Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hexgrid and circular grid to the osu editor #26310

Merged
merged 12 commits into from
Jul 3, 2024

Merge branch 'master' into grids-2

17ce9cd
Select commit
Loading
Failed to load commit list.
Merged

Add hexgrid and circular grid to the osu editor #26310

Merge branch 'master' into grids-2
17ce9cd
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed succeeded Jul 3, 2024 in 0s

1 / 1 tasks completed

All tasks have been completed

Details

Required Tasks

Task Status
#26309 Completed
The triangular grid seems neat but the adjustment bounds (specifically rotation) seem weird. With triangular grid the rotation bounds should be [-30deg, 30deg] not [-45deg, 45deg] (because of central symmetry only 60deg of movement is required to get all possible spatial orientations) Incomplete
I'm not sure how to feel about the mere existence of the circular grid. We already have a circular grid, it's just beat-snapped. Is a non-snapped circular grid even going to be useful to anyone? As in, a circular grid to me can seemingly only be used for either making circles of keeping distances equal between objects, at which point you probably want grid snap too for constant movement velocity. Incomplete
When circular grid and beat snap grid are active with low spacing, the intersection snapping feature breaks down in that it's hard to even predict what is going to happen, especially when both sets of circles begin to be near-concentric: Incomplete
The expand/collapse behaviour of the menu is very annoying since clicking it doesn't seem to trigger it and instead it expands on hover with a delay, making the menu feel very unresponsive Incomplete
The grid is barely visible on 4k screens, I have to use background dim >75% to be able see it well Turns out this was my monitor struggling with contrast for this particular combination of colors, fixed by changing some monitor settings Incomplete
The hamburger button toggle next to the menu section has no visible effect on click, leaving me confused about what it actually does at first Incomplete
When the grid menu is collapsed, and my cursor touches the grid box on it's way to the rotate/scale buttons, the grid menu expands on hover and will push the buttons I actually wanted to click off-screen. Incomplete
The rectangular & triangle grid appear to have no anti-aliasing, while the circle grid does Incomplete
The layout of the menu generally just completely changes on hover, my mouse cursor basically never lands on the thing I originally hovered on after it expanded Incomplete
The button to toggle grid snap should be paired with the grid settings imo, I had to look for it when I wanted to turn it on only to find it in very bottom left of the screen (same thing goes for distance snap too) Incomplete
I think the 1-letter abbreviations for the values are kinda confusing (R could mean Rotation, Radius, ...). There should be enough space to actually write out the words rotation and spacing, so no value in using these abbreviations. The angle should probably also have a degree symbol at the end. Incomplete
The collapsed menu doesn't show the type of grid currently selected Incomplete
The collapsed menu wastes a lot of space with margin between the individual lines Incomplete
I think having these values shown at all is kind of pointless because I can just look at the actual grid which tells me so much more than those values. Incomplete
There should be text fields for each of the values. I don't wanna waste time micro-adjusting the sliders to get the correct values dialed in when I can just type it out Incomplete
The slider limits should be changed to match the range that makes sense for each grid type, and hidden for the circle grid Incomplete
The sliders should have "soft" limits: when you change from a grid with -45/45 range to a grid with -30/30 range, the value should be kept, and the limits only applied once I touch the slider Incomplete
The rotation text box (if there is one) should not try to somehow fit the values inside the given range (Software changing my values on enter is just super annoying and never ever feels good). Incomplete
Buttons to increment/decrement the value by 1 would also be nice to have on the left/right side of the slider/text field Incomplete
This is probably out of scope for this PR, but it would be nice to have draggable "handles" on the playfield while editing the grid. Using x/y/scale/rotation/whatever is generally a bit of a pain when making adjustments to the grid. I'd only really wanna use those if I want precise values, but not when just adjusting the grid by "vibe" Incomplete
The grid type buttons use a lot of vertical space right now since they're arranged vertically. I think having either a horizontal button group would or a dropdown select would work better here. Incomplete
This should probably be inside a popup menu, don't think there's a need for it to use this much space in the side menu, especially since it currently leads to the issue of pushing other menus off-screen on hover Incomplete
I would like a keyboard shortcut for bringing up the grid menu (so I can avoid having to use the sidebar) Incomplete
It would be cool to have the option to completely disable the grid Incomplete