-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert relative filepath for security reason #20
Comments
@Jxck Thank you for your comment. You are absolutely right. Using relative paths is already planned in next release, but now I'm reminded I have to hurry. I'm so sorry for my insensitiveness. Next version will be released soon. |
it seems some commits but not fixed yet in current version |
@Jxck Sorry for slow progress. power-assert is now in 1.0.0 release process. To be released today or tomorrow. |
🙏🍻🍻🍻🙏 |
@Jxck, instrumentors below are using
More to come (PRs are already proposed): |
This issue is fixed by the 1.0.0 release of power-assert family. |
great work thanks :) |
power-asserted test result includes
filepath
with 'full path' like this.file path with full path is kind of sensitive information in server or developer machine.
if user doesn't know this behavior, it may cause some security issue.
(for example, some could forgot adding build result to gitignore and push to public repository.)
I think this information is only a project specific.
so it seems better for me to use relative path of test file or project or configurable base bath.
any comments ?
The text was updated successfully, but these errors were encountered: