-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplication in the error's stack and message #19
Comments
Using this configuration: https://gist.github.com/rstacruz/f2fb7214d907aad1c250 |
@rstacruz Thank you for reporting!
I think so too. This problem should be fixed ASAP. Duplication appears since mocha 2.2.3, maybe since this commit. I'll isolate the problem to determine which is wrong (power-assert or mocha), then fix or PR it soon. Thanks! |
Ah this problem is due to this change (Shorten stack traces). Filepath is shortened to relative path to the deploy folder, on the other hand Assertion message created by power-assert is absolute filepath. So first line in stack and assertion message does not match, stack is preserved, duplication appears. I'll try to store relative paths in power-assert message. |
heh, considering that feature came from my work, i guess indirectly I caused that ;) |
This issue is fixed by the 1.0.0 release. |
congrats on the 1.0 release! |
@rstacruz Thanks! :) |
In mocha, the power-assert messages are displayed on both the stack and the message... it's a bit redundant.
The text was updated successfully, but these errors were encountered: