fix: fix the filepath of the stack

[popomore]

This error is introduced by #6

How to reproduce

// index.js
require('intelli-espower-loader');
require('./test/index.test.js');

// test/index.test.js
throw new Error(1);

run node index.js, then you can see the wrong path /Users/popomore/code/tmp/test/test/index.test.js

/Users/popomore/code/tmp/test/test/index.test.js:1
throw new Error(1);
      ^
Error: 1
    at Object.<anonymous> (/Users/popomore/code/tmp/test/test/index.test.js:1:7)
    at Module._compile (module.js:570:32)
    at Object.extensions..js (/Users/popomore/code/tmp/node_modules/.1.2.1@espower-loader/index.js:46:25)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/Users/popomore/code/tmp/index.js:2:1)
    at Module._compile (module.js:570:32)

[shepherdwind]

If remove this, the ts path will be wrong. For example

// index.js
require('intelli-espower-loader');
require('./test/foo.test.js');

// test/foo.test.js
throw new Error('123');
//# sourceMappingURL=data:application/json;base64,eyJ2ZXJzaW9uIjozLCJmaWxlIjoiZm9vLnRlc3QuanMiLCJzb3VyY2VSb290IjoiIiwic291cmNlcyI6WyJmb28udGVzdC50cyJdLCJuYW1lcyI6W10sIm1hcHBpbmdzIjoiQUFJQSxNQUFNLElBQUksS0FBSyxDQUFDLEtBQUssQ0FBQyxDQUFDIn0=

and run node index.js

Error: 123
    at Object.<anonymous> (foo.test.ts:5:7)
    at Module._compile (module.js:571:32)
    at Object.extensions..js (/Users/eward/test/foo/node_modules/.npminstall/espower-loader/1.2.1/espower-loader/index.js:45:25)
    at Module.load (module.js:488:32)

[popomore]

@shepherdwind can you give us the code which is generating the sourcemap by ts

[popomore]

It seems convert-source-map will use the sourcemap which is generated by typescript.

[shepherdwind]

I know what is the problem now.

The first example, js file don't have sourcemap comment, so there is not source map and source path. Then the source path lookup by the function adjustFilepath. The source file path will be a relative path , for example test/index.test.js .

And the next example, js code have some source map comment. And ts source map file source just a file name ,not a path, for example index.test.ts.

I don't know if we can change adjustFilepath to return the file name?

[twada]

@shepherdwind Would you create a small project or gist to reproduce your issue? I'll investigate the problem.

[shepherdwind]

@twada here is the gist https://gist.github.com/shepherdwind/02a903c06f2dabb67229911d771280ab .

[twada]

@shepherdwind Thanks for the repro case.

I'm going to accept @popomore's PR since correct and relative filepath is more important to power-assert for security reason and for users using power-assert on browsers. espower-source makes every path relative to project root (that's why adjustFilepath function exists).

SourceMap that espower-loader reads is generated by espower-source, that is reconnected with the original SourceMap by multi-stage-sourcemap. Original SourceMap may contain multiple sources stored in different directories. It's difficult to set sourceRoot after the sourcemap processing.

@shepherdwind, is there any way to make TypeScript storing more informative paths instead of basename?

[shepherdwind]

Ok, I will try to do something to add more info for typescript source map. Accept this pr is fine.

[okoala]

fix it quickly, Please 😖

[twada]

@okoala @popomore Okay I'm going to release soon.

[twada]

Just released espower-loader 1.2.2

[popomore]

@twada thx

[okoala]

@twada good