feat: Restructure and expand export_template files
#144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…late file
* Adds `{{title}}` as a template parameter.
* Consolidate app-launching code in `runExportedApp()`.
* Pick up app mode from the `mode` query parameter.
* `edit/index.html` now redirects to `index.html?mode="editor-terminal-viewer"`.
This was referenced Jun 28, 2024
gadenbuie
commented
Jun 28, 2024
schloerke
reviewed
Jun 28, 2024
schloerke
reviewed
Jun 28, 2024
schloerke
approved these changes
Jun 28, 2024
georgestagg
reviewed
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consolidates the JavaScript for launching an exported shiny app into
runExportedApp()to avoid duplicating logic between theindex.htmltemplate file andedit/index.html:{{title}}as a template parameter.runExportedApp().modequery parameter.edit/index.htmlnow redirects toindex.html?mode=editor-terminal-viewer.{{{include_in_head}}}for content just before</head>{{{include_before_body}}}for content just after<body>{{{include_after_body}}}for content just before</body>These changes are intended to help with
Ready for review in conjunction with the following PRs. I've tested this PR in both Python and R exports, but let me know if I can provide guidance for testing locally.
--template-dirand--template-parampy-shinylive#32