feat: Customize export template and parameters #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise `glue::glue()` will just return an empty string. This gives a much better and more focused error message.
gadenbuie
commented
Jun 28, 2024
Treat `.html` files as templates for interpolation, and copy all other files as-is.
gadenbuie
force-pushed
the
feat/update-export-template
branch
from
63bbac2
to
7820314
Compare
schloerke
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32
Pairs with posit-dev/shinylive#144
Adds
template_dirandtemplate_paramstoshinylive::export().template_dirallows users to customize theindex.htmlfile used by the exported app. This argument takes a path that, effectively, supercedes the path in the shinylive assets.template_paramstakes a list of template parameters. https://github.com/posit-dev/shinylive/pull/144/files introduces a new set of template params, e.g.{{ title }}. This argument also covers parameters introduced by custom templates, or future parameters added to the default shinylive template.I initially used
glue::glue()for the interpolation, but realized while working on the Python side of this change that that it won't be easy to replicate glue's interpolation behavior in Python.Instead, I decided to use
whiskerso that both implementations can use mustache for templating. I think this is a net win, as it allows for more powerful templating for power users without overly complicating the feature.