feat: Allow CSS units in viewerHeight option
#140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wch
approved these changes
Jun 14, 2024
wch
reviewed
Jun 14, 2024
Comment on lines
+10
to
+12
| if (typeof value !== "number") { | ||
| return undefined; | ||
| } |
There was a problem hiding this comment.
Yeah, it'd have to be a value that makes it past the type checker. Happy to take this out if its unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
viewerHeightshould take any CSS unit quarto-ext/shinylive#36Adds a utility function,
asCssLengthUnit(), that promotes numbers to pixels or otherwise passes through a string value. This enablesviewerHeight: 300→300pxas in the current behavior orviewerHeight: 300px(or any other CSS unit).