Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

viewerHeight should take any CSS unit #36

Closed
gadenbuie opened this issue Dec 29, 2023 · 0 comments · Fixed by posit-dev/shinylive#140
Closed

viewerHeight should take any CSS unit #36

gadenbuie opened this issue Dec 29, 2023 · 0 comments · Fixed by posit-dev/shinylive#140

Comments

@gadenbuie
Copy link
Collaborator

viewerHeight: 300 becomes style="height: 300px", but viewerHeight: 300px is silently ignored.

At the very least, viewerHeight should support pixel units, but, if feasible, any valid CSS unit should be allowed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Allow CSS units in viewerHeight option posit-dev/shinylive
1 participant
@gadenbuie