Update InjectAutoreloadMiddleware to be compatible with starlette >= 0.35.0#1013
Merged
Update InjectAutoreloadMiddleware to be compatible with starlette >= 0.35.0#1013
InjectAutoreloadMiddleware to be compatible with starlette >= 0.35.0#1013Conversation
…but be typed with asgiref.types
Collaborator
|
I think the root of this problem is: However, in Kludex/starlette#2381, the explicit types they added are the starlette types, not the asgiref types, and that's why we started getting type-checking errors. The change in this PR makes it so, on the outside, it uses the starlette types, but on the inside, it uses the asgiref types. I think it would be better if the external interface supported both types. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: Kludex/starlette#2381
Do not merge until motivation for #1009 is resolved