Disable Microsoft telemetry #2882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliasilge
commented
Apr 24, 2024
Comment on lines
+150
to
+153
| // --- Start Positron --- | ||
| // 'default': true, | ||
| 'default': false, | ||
| // --- End Positron --- |
There was a problem hiding this comment.
I feel like this one could be argued either way (keep or remove) but I would vote for removing.
petetronic
reviewed
Apr 24, 2024
| // --- Start Positron --- | ||
| // const endpointUrl = 'https://mobile.events.data.microsoft.com/OneCollector/1.0'; | ||
| // const endpointHealthUrl = 'https://mobile.events.data.microsoft.com/ping'; | ||
| const endpointUrl = 'https://mobile.events.0.0.0.0/OneCollector/1.0'; |
There was a problem hiding this comment.
While that is an invalid host, were we literally trying to use 0.0.0.0 to be IP of "this machine" or even an invalid IP, and if so, should we drop mobile.events. prefix? With telemetry disabled, I trust these URLs aren't actually used, though.
There was a problem hiding this comment.
Ah, that's probably better, yes
petetronic
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
Addresses #2522
Approach
This PR takes a similar approach as VSCodium. I took a look at this info when deciding what to do/remove:
QA Notes
To see if there are other references to these servers, you can search for
data.microsoft.comin the codebase.Also, you can try rebuilding Positron from scratch and then doing
rg --no-ignore -l "data.microsoft.com" .from Positron's directory. You'll see a lot of stuff, but it is onlynode_modules. If you dorg -l "data.microsoft.com" .you'll only see the1dsAppender.tswe have edited here in this PR.