Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexible support configuration #485

Merged
merged 12 commits into from
Feb 11, 2025
Merged

Conversation

MattWellie
Copy link
Collaborator

@MattWellie MattWellie commented Feb 11, 2025

Fixes

  • We have no way of flexing the importance of any individual category from full to support via configuration

Proposed Changes

  • removes reference to "categorysupportX" in the documentation, that name prefix is no longer a usable mechanic
  • adds a support_categories entry to the config template, this is pulled into each variant as an attribute, and contains the names of all the categories to use with second-tier importance
  • reeeeeeallly simplifies the logical tests. Instead of treating full and support categories separately, and having a test for each combination, this is boiled down to a single method:
  1. get all the categories that apply to this variant (Boolean) and this [sample + variant] (Sample) as a set of Strings
  2. if support is not being used in this test, subtract all the category names in the support_categories list
  3. return True if there's anything left in the list

ALSO

Adds a configurable minimum number of alt-supporting reads for a variant to reach the report

Checklist

  • Related Issue created
  • Tests covering new change
  • Linting checks pass

@MattWellie MattWellie requested a review from cassimons February 11, 2025 06:19
Copy link
Collaborator

@cassimons cassimons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@MattWellie MattWellie merged commit e52e637 into main Feb 11, 2025
5 checks passed
@MattWellie MattWellie deleted the flexible_support_configuration branch February 11, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants