Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log mysterious QoB 400 client errors in detail #358

Merged
merged 1 commit into from
Jan 19, 2025
Merged

Log mysterious QoB 400 client errors in detail #358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion hail/src/main/scala/is/hail/services/package.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,10 @@ package object services {
) || e.getMessage.contains("Unexpected end of file")) =>
true
case e: HttpResponseException
if e.getStatusCode() == 400 =>
if e.getStatusCode() == 400 && e.getMessage != null && (
e.getMessage.contains("Invalid grant: account not found") ||
e.getMessage.contains("{\"error\":\"unhandled_canonical_code_14\"}")
) =>
true
case e: IOException
if e.getMessage != null && e.getMessage.contains("Connection reset by peer") =>
Expand Down Expand Up @@ -181,6 +184,16 @@ package object services {
}
}

def isCPGMysteryError(_e: Throwable): Boolean = {
val e = is.hail.shadedazure.reactor.core.Exceptions.unwrap(_e)
e match {
case e: HttpResponseException
if e.getStatusCode() == 400 =>
true
case _ => false
}
}

def retryTransientErrors[T](f: => T, reset: Option[() => Unit] = None): T = {
var tries = 0
while (true) {
Expand All @@ -196,6 +209,15 @@ package object services {
s"${5 - tries} more times. Do not be alarmed. (next delay: " +
s"$delay). The most recent error was $e."
)
} else if (tries <= 10 && isCPGMysteryError(e)) {
val e2 = is.hail.shadedazure.reactor.core.Exceptions.unwrap(e)
val msg = e2.getMessage
val retrying = if (tries <= 9) " Retrying." else ""
if (msg != null) {
log.warn(s"Encountered CPG mystery 400 error: $e2 with message $msg.$retrying")
} else {
log.warn(s"Encountered CPG mystery 400 error: $e2 without message.$retrying")
}
} else if (!isTransientError(e)) {
throw e
} else if (tries % 10 == 0) {
Expand Down