Set large StreamReadConstraints.maxStringLength for IR parsing only #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enlarge the maxStringLength just before parsing the (perhaps huge!) IR and reset it to the default immediately afterwards. If this code is multithreaded and other threads also parse JSON, there is a race condition here. It would be better to construct a bespoke JsonFactory to parse this IR, but expressing that while satisfying the type checker requires more Scala knowledge than we have.
vivbak
approved these changes
Dec 9, 2024
|
This turns out to be a red herring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enlarge the maxStringLength just before parsing the (perhaps huge!) IR and reset it to the default immediately afterwards.
If this code is multithreaded and other threads also parse JSON, there is a race condition here. It would be better to construct a bespoke JsonFactory to parse this IR, but expressing that while satisfying the type checker requires more Scala knowledge than we have.