Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the metadata server .../service-accounts/.../scopes endpoint #338

Merged
merged 1 commit into from
May 27, 2024

Conversation

jmarshall
Copy link

Follow-up to PR #337, context: https://centrepopgen.slack.com/archives/C04M1G5HLM9/p1716767294970409?thread_ts=1716528932.818119&cid=C04M1G5HLM9

The code that parses this response (in apitools/base/py/utils.py's NormalizeScopes()) appears to be wanting a whitespace-separated bunch of words. We write this one-per-line as per other endpoints, e.g. user_service_account().

@jmarshall jmarshall requested a review from illusional May 27, 2024 00:23
@jmarshall jmarshall merged commit d7191ed into main May 27, 2024
@jmarshall jmarshall deleted the scopes-endpoint branch May 27, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants