Skip to content

Correction to star summary method #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 23, 2025
Merged

Correction to star summary method #12

merged 3 commits into from
Jan 23, 2025

Conversation

MattWellie
Copy link
Collaborator

Purpose

  • Closes Check the star-assignment logic #11
  • When we calculate the number of stars for a submission, we were considering the Uncertain/Unknown submissions. If an allele had a 0-star Pathogenic and a 1-star Uncertain, the result would be Pathogenic (due to the tie-breaking) and 1-star (from the Uncertain)

Proposed Changes

  • When calculating Stars, we skip over Uncertain/Unknown-rated submissions
  • adds test cases to confirm all combinations

Checklist

  • Related GitHub Issue created
  • Tests covering new change
  • Linting checks pass

@MattWellie MattWellie requested a review from cassimons January 23, 2025 06:56
@MattWellie MattWellie merged commit 06ad881 into main Jan 23, 2025
2 checks passed
@MattWellie MattWellie deleted the correction_to_star_summary branch January 23, 2025 07:06
MattWellie added a commit that referenced this pull request Feb 10, 2025
@MattWellie
Correction to star summary method (#12)
00e0168
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cassimons cassimons cassimons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check the star-assignment logic
2 participants
@MattWellie @cassimons