Repository navigation
Conversation
Assisted-by: Codex:gpt-6.1-sol
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Closes #1523
Description
After an app process stopped, an exception while reading the head pose could leave
current_appin thestoppingstate. Later start and stop requests then failed until the daemon restarted.This change logs failures from the post-stop pose handling and clears
current_appin afinallyblock. The existing return-to-zero and sleep-pose behavior is unchanged when pose handling succeeds.Suggested labels:
bug,motors. This account does not have permission to apply labels.Testing
test_stop_clears_current_app_when_pose_read_failsfailed withRuntimeError: pose unavailable.python -m pytest tests/unit_tests/test_app_stop_sleep.py -vv --tb=short: 3 passed.ruff checkandruff format --check: passed.mypy src/reachy_mini/apps/manager.py: passed.Only the listed library tests with mocks are claimed as validation. No hardware or simulator result is claimed.
Tested on
--sim)--mockup-sim)AI assistance
An AI agent generated the code and this PR description. Review responses must be written by the human author in their own words.