Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement #64 : adding say text method #65

Closed
wants to merge 3 commits into from

Conversation

FabienDanieau
Copy link
Contributor

Check if the generated pb2 are ok.

Version of the tools in my env:
grpcio 1.59.2
grpcio-tools 1.59.2
protobuf 4.25.0

@FabienDanieau FabienDanieau linked an issue Nov 15, 2023 that may be closed by this pull request
Copy link
Member

@glannuzel glannuzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we don't have the same version to generate the python files, as they are all modified here.

Since the package name is now reachy2_sdk_api instead of reachy_sdk_api_v2, the pb folder with name reachy_sdk_api_v2 is not necessary anymore.
@simheo
Copy link
Member

simheo commented Nov 17, 2023

Closing this pull request as I fear that there will be too much conflict with develop branch.
There are two problems in this situation:

  1. renaming: recently the library name has changed from reachy-sdk-api-v2 to reachy2-sdk-api. Here in the branch the former naming was used hence the pb file generated in the reachy_sdk_api_v2 folder.
  2. grpc libraries versions. Because no version is specified for each of the libraries used to generate the pb files, each and every one of us has a different setup to generate the pb files. This can lead to massive git diff when doing the pull requests just like here.

I will generate the pb files for the changes you made @FabienDanieau in #68. I opened the issue #69 to specify the versions for the protobuf libraries and generate properly once and for all the pb files in a setup that we can all have on our laptops.

@simheo simheo closed this Nov 17, 2023
@simheo simheo deleted the 64-make-proto-for-text-to-speech branch November 17, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make proto for text to speech
3 participants