Skip to content

feat: Add initial support for Metadata V16 view_functions#6135

Closed
demoncoder-crypto wants to merge 1 commit intopolkadot-js:masterfrom
demoncoder-crypto:feat/metadata-v16-view-functions
Closed

feat: Add initial support for Metadata V16 view_functions#6135
demoncoder-crypto wants to merge 1 commit intopolkadot-js:masterfrom
demoncoder-crypto:feat/metadata-v16-view-functions

Conversation

@demoncoder-crypto
Copy link
Copy Markdown

Addresses #6133

@valentinfernandez1
Copy link
Copy Markdown
Contributor

Thanks for putting this together, I appreciate the effort here.

That said, I think the approach might need to be rethought a bit. A lot of the files touched in this PR are auto-generated (they explicitly state // Auto-generated via yarn polkadot-types-from-defs, do not edit) and so editing them directly isn’t the right path.

Also, some of what’s being added here overlaps with the upcoming Metadata V16 PR so it probably makes more sense to wait until that lands, then build on top of it, otherwise we risk redoing work or introducing conflicts. Not saying that this effort isn't valuable but it might be a good idea to hold off until the Metadata 16 stuff is merged

@demoncoder-crypto
Copy link
Copy Markdown
Author

Understood I will wait till metadata V16 Pr, also please tell on what changes or what tangent do you want me to implement the changes I am very willing to make the desired changes. Thanks :). @valentinfernandez1

@valentinfernandez1
Copy link
Copy Markdown
Contributor

Closing as this PR is outdated

@polkadot-js-bot
Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Aug 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants