System chains governace authorizes upgrade tests #783

karolk91 · 2025-06-24T19:30:11Z

This PR introduces test case scenarios to verify if parachain is able to process authorize_upgrade call as if it was send via governance chain (a Relay Chain for purpose of this PR)

These test cases were introduced to polkadot-sdk and suggested via comment that it would be nice to port, so this is just integration of existing testnets cases for production networks

This PR also introduces integration tests covering all system chains that simulates real network upgrade using whitelisting (via Collectives chain in case of Polkadot)

Test Coverage

Chain	Unit Tests	Integration Tests
Polkadot Asset Hub	✅	✅
Polkadot Coretime	✅	✅
Polkadot Collectives	✅	✅
Polkadot Bridge Hub	✅	✅
Polkadot People	✅	✅
Kusama Asset Hub	✅	✅
Kusama Coretime	✅	✅
Kusama Bridge Hub	✅	✅
Kusama People	✅	✅
Kusama Encointer	✅	Lack of mocked network definition here
Kusama Relay	Not applicable	✅
Polkadot Relay	Not applicable	✅
Kusama Glutton	Not supported: `BasicParachainRuntime` not implemented	Lack of mocked network definition here

Follow-up:

For AHM, we will add also the tests for OpenGov on AHs:
#776
#626

bkontur · 2025-06-25T10:15:08Z

system-parachains/encointer/src/xcm_config.rs

 	pub UniversalLocation: InteriorLocation =
 	[GlobalConsensus(RelayNetwork::get()), Parachain(ParachainInfo::parachain_id().into())].into();
 	pub StakingPot: AccountId = CollatorSelection::account_id();
+	pub const GovernanceLocation: Location = Location::parent();


@karolk91 just thinking, can we just define this in the test file directly, when it is not used here? I think later we will have this constant here: https://github.com/polkadot-fellows/runtimes/blob/main/system-parachains/constants/src/kusama.rs#L153 right?

@karolk91 just thinking, can we just define this in the test file directly, when it is not used here? I think later we will have this constant here: https://github.com/polkadot-fellows/runtimes/blob/main/system-parachains/constants/src/kusama.rs#L153 right?

I should probably just introduce this common constant as part of this PR

I have introduced GovernanceLocation to common package in b5a8792. I have dropped const modifier because in future I expect it to point to AssetHubLocation and we would need to drop const anyway

@bkontur, I have followed the convention that GovernanceLocation is re-exported via xcm_config for every chain. In case of Encointer its only used for testing, do you think its worth breaking the convention for this single occurence and import straight in tests instead of via xcm_config ?

bkontur

@karolk91 Good job! This PR captures the current state as-is with tests and will be useful when moving OpenGov to the AssetHubs - #626 and #776

acatangiu · 2025-06-25T13:58:46Z

system-parachains/encointer/src/xcm_config.rs

 	pub UniversalLocation: InteriorLocation =
 	[GlobalConsensus(RelayNetwork::get()), Parachain(ParachainInfo::parachain_id().into())].into();
 	pub StakingPot: AccountId = CollatorSelection::account_id();
+	pub const GovernanceLocation: Location = Location::parent();


github-actions · 2025-06-25T19:14:39Z

Review required! Latest push from author must always be reviewed

Co-authored-by: Karol Kokoszka <[email protected]>

Governance integration tests on Kusama (by karolk91) (for OpenGov on RC)

bkontur

@karolk91 please, add to the desc, that we are adding also governance integration emulated tests, which simulates the real usage how we upgrade live chains and

Follow-up section:

For AHM, we will add also the tests for OpenGov on AHs:
#776
#626

integration-tests/emulated/helpers/src/lib.rs

Co-authored-by: Branislav Kontur <[email protected]>

bkontur · 2025-06-26T15:12:32Z

integration-tests/emulated/tests/governance/kusama/src/open_gov_on_relay.rs

+	);
+
+	// whitelist
+	Kusama::execute_with(|| {


@karolk91 Karol, we forgot to add and use here macro_rules! assert_whitelisted { :), please

…-main

…rc3`

pandres95

Overall, looks good. Just a minor nit, but can be handled on a further PR.

pandres95 · 2025-07-11T02:02:14Z

Cargo.lock

 [[package]]
 name = "emulated-integration-tests-common"
-version = "20.1.0"
+version = "21.0.0"


Open question: Wouldn't it make sense to upgrade the entire set of dependencies to the latest patch version, now that we're making changes on Cargo.lock?

Open question: Wouldn't it make sense to upgrade the entire set of dependencies to the latest patch version, now that we're making changes on Cargo.lock?

Well, in the past we did both - PR with patch upgrade and also PR with just few patch deps upgrade - I think both ways are ok. We can do follow-up to bring the full stable2503-7

pandres95 · 2025-07-11T02:03:38Z

Cargo.toml

 frame-election-provider-support = { version = "40.1.1", default-features = false }
 frame-executive = { version = "40.0.1", default-features = false }
 frame-support = { version = "40.1.0", default-features = false }
-frame-system = { version = "40.1.0", default-features = false }


Think it'd definitely be better if we update other related deps in the PSDK, to prevent having multiple versions of the crates pinned to multiple dependants. This tends to be messy sometimes,

bkontur · 2025-07-11T06:53:35Z

/merge

fellowship-merge-bot · 2025-07-11T06:55:21Z

Enabled auto-merge in Pull Request

Available commands

/merge: Enables auto-merge for Pull Request
/merge cancel: Cancels auto-merge for Pull Request
/merge help: Shows this menu

For more information see the documentation

karolk91 added 13 commits June 24, 2025 15:58

AssetHub Polkadot runtime governance tests

53848f2

asset-hub-polkadot/tests/tests.rs formatting

29fdae3

Kusama Asset Hub governance_authorize_upgrade_works tests

f7fd878

Polkadot Collectives governance_authorize_upgrade_works tests

63264cb

Kusama Bridge Hub governance_authorize_upgrade_works tests

ef345be

Polkadot Bridge Hub governance_authorize_upgrade_works tests

953c071

Polkadot Coretime governance_authorize_upgrade_works tests

cd25eba

Kusama Coretime governance_authorize_upgrade_works tests

162cd0b

Kusama People governance_authorize_upgrade_works tests

9ecf93d

Polkadot People governance_authorize_upgrade_works tests

b0f9ee2

coretime-kusama/src/tests.rs formatting

256705e

Add CHANGELOG.md entry

d4f27a6

Kusama Encointer governance_authorize_upgrade_works tests

b3abdc4

karolk91 marked this pull request as ready for review June 25, 2025 08:32

bkontur reviewed Jun 25, 2025

View reviewed changes

bkontur approved these changes Jun 25, 2025

View reviewed changes

acatangiu mentioned this pull request Jun 25, 2025

Ensure that the system parachains can accept XCM calls (authorize_upgrade) from the AssetHub and/or Collectives governance systems. paritytech/polkadot-sdk#7566

Closed

3 tasks

acatangiu approved these changes Jun 25, 2025

View reviewed changes

karolk91 added 2 commits June 25, 2025 21:12

Move GovernanceLocation definition to common package

b5a8792

Add missing Encointer tests folder

4c22aa3

github-actions bot requested review from acatangiu and bkontur June 25, 2025 19:14

bkontur and others added 3 commits June 26, 2025 10:21

Governance integration tests on Kusama (by karolk91) (for OpenGov on RC)

4ebe058

Co-authored-by: Karol Kokoszka <[email protected]>

Merge pull request #3 from bkontur/bko-on-kk-governance-tests-main

e9f34fe

Governance integration tests on Kusama (by karolk91) (for OpenGov on RC)

Add Polkadot governance integration tests

04b452b

bkontur reviewed Jun 26, 2025

View reviewed changes

Fix zepter check findings

47bcf1b

karolk91 changed the title ~~System chains governace authorizes upgrade unit tests~~ System chains governace authorizes upgrade tests Jun 26, 2025

Apply suggestions from code review

13cd583

Co-authored-by: Branislav Kontur <[email protected]>

github-actions bot requested a review from bkontur June 26, 2025 12:38

bkontur reviewed Jun 26, 2025

View reviewed changes

Assert whitelisted event for Kusama tests

d1fe976

github-actions bot requested a review from bkontur June 26, 2025 20:12

bkontur approved these changes Jun 27, 2025

View reviewed changes

Merge remote-tracking branch 'upstream/main' into kk-governance-tests…

1b419d2

…-main

bkontur approved these changes Jul 3, 2025

View reviewed changes

github-actions bot requested a review from bkontur July 3, 2025 08:10

bkontur approved these changes Jul 3, 2025

View reviewed changes

acatangiu approved these changes Jul 3, 2025

View reviewed changes

bkontur added 4 commits July 8, 2025 10:57

Merge branch 'main' into kk-governance-tests-main

18902b4

Bump emulated-integration-tests-common from `polkadot-stable2503-7-…

2f57c56

…rc3`

Change assert to assert_eq

a2c455f

Deps cleanup

58574bb

bkontur approved these changes Jul 9, 2025

View reviewed changes

Bump nit

b3400e3

tdimitrov approved these changes Jul 10, 2025

View reviewed changes

Ping CI - docker, docker...

d0c6a9a

pandres95 approved these changes Jul 11, 2025

View reviewed changes

fellowship-merge-bot bot merged commit 089c589 into polkadot-fellows:main Jul 11, 2025
66 checks passed

bkontur deleted the kk-governance-tests-main branch July 11, 2025 06:56

System chains governace authorizes upgrade tests #783

System chains governace authorizes upgrade tests #783

Uh oh!

Conversation

karolk91 commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Coverage

Follow-up:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bkontur left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jun 25, 2025

Uh oh!

bkontur left a comment

Choose a reason for hiding this comment

Follow-up section:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pandres95 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bkontur commented Jul 11, 2025

Uh oh!

Uh oh!

fellowship-merge-bot bot commented Jul 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

karolk91 commented Jun 24, 2025 •

edited

Loading