Ensure Consistent Topic IDs for Traceable Cross-Chain XCM #739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-Enable as last step
TODO: - Resolve the `Imbalance` type mismatch on `pallet_staking`
…ves parachain runtime TODO: Check whether we need some `AuthorizedAliasingConsideration`.
…rachains' runtimes TODO: Check whether we need some `AuthorizedAliasingConsideration`.
…ub parachains' runtimes TODO: - important: `core` rewrite over `sp_io`. Can't compile `bridge-hub-polkadot-runtime`. Can't figure out which dependency has the `std` open. - Check whether we need some `AuthorizedAliasingConsideration`.
… parachains' runtimes TODO: - important: `core` rewrite over `sp_io`. Can't compile both parachain runtimes. Can't figure out which dependency has the `std` open. - Check whether we need some `AuthorizedAliasingConsideration`.
[At/2503] Pass compilation for several runtimes
Fix BH migraitons
Fix BHP benchmarks
…knumber-migration Add broker block number migration and fix tests
…tion fix Polkadot SDK stable2503 integration and fix integration tests
# Conflicts: # CHANGELOG.md # Cargo.lock # Cargo.toml # relay/kusama/src/lib.rs
Contributor
Author
|
Depends on #711 |
# Conflicts: # CHANGELOG.md # Cargo.lock # Cargo.toml # relay/kusama/src/lib.rs # relay/polkadot/src/lib.rs # system-parachains/bridge-hubs/bridge-hub-kusama/src/lib.rs
acatangiu
reviewed
Jun 6, 2025
Contributor
acatangiu
left a comment
acatangiu
left a comment
There was a problem hiding this comment.
@raymondkfcheung please squash all the commits - currently the PR shows all the commits from PR711 which was already merged
Comment on lines
+38
to
+40
| Kusama::execute_with(|| { | ||
| Dmp::make_parachain_reachable(CoretimeKusama::para_id()); | ||
| }); |
Contributor
There was a problem hiding this comment.
hmm how did these pass before?
Contributor
Author
There was a problem hiding this comment.
I'm not sure why. But these two tests are failed locally.
Contributor
There was a problem hiding this comment.
hmm how did these pass before?
Explained here: #759 (comment)
Contributor
Author
|
Closing it, in favour of #759. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures every XCM processed with the same topic ID across multiple chains to improve traceability.
Partially addresses paritytech/polkadot-sdk#6119 and relates to paritytech/polkadot-sdk#7691.