Split base fee and tip handling#700
Merged
sorpaas merged 3 commits intopolkadot-evm:masterfrom May 23, 2022
Merged
Conversation
sorpaas
approved these changes
May 23, 2022
abhijeetbhagat
pushed a commit
to web3labs/frontier
that referenced
this pull request
Jan 11, 2023
* Split base fee and tip handling * Return `NegativeImbalance` * clippy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The motivation for this is, currently is not possible to reproduce the Ethereum behaviour, as it was previously noticed by @icodezjb in #646, although that proposal was initially discarded because it didn't fullill some of the use cases (i.e. ability of not paying the author, even if there are priority fees).
This PR changes the
OnChargeEVMTransactiontrait to handle base fee and tip fees separately:correct_and_deposit_feewill issue the refund and call on_unbalanced with just the base fee, returning theNegativeImbalanceof the eventual tip.pay_priority_feetakes theNegativeImbalanceas an argument.This way one can:
on_unbalancedand pay the remainingNegativeImbalanceto the block author.