Conversation
tgmichel
added
B7-runtimenoteworthy
notlesh
reviewed
May 20, 2022
notlesh
reviewed
May 20, 2022
| >>::correct_and_deposit_fee(who, corrected_fee, already_withdrawn) | ||
| } | ||
|
|
||
| fn pay_priority_fee(_tip: U256) {} |
Contributor
There was a problem hiding this comment.
It amuses me how subtle this is in code...
Contributor
There was a problem hiding this comment.
Is it necessary to add some docs about this?
Contributor
Author
There was a problem hiding this comment.
@AsceticBear PTAL to polkadot-evm/frontier#700
I thought about it this past days, and decided to slightly modify the approach in Frontier. I think splitting both base fee and priority fee handling offers the most flexibility in terms of how each chain wants to deals with them.
notlesh
approved these changes
May 20, 2022
girazoki
approved these changes
May 23, 2022
tgmichel
added
D9-needsaudit👮
crystalin
approved these changes
May 23, 2022
notlesh
added
D1-audited👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
OnChargeEVMTransactionimplementation for both Moonbeam and Moonriver.What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?