Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Produce all available statistical maps from each analysis unit #131

Merged
merged 10 commits into from
Apr 30, 2019

Conversation

effigies
Copy link
Collaborator

@effigies effigies commented Apr 18, 2019

Fixes #124.
Closes #125.
Closes #133.

@effigies
Copy link
Collaborator Author

@tyarkoni @adelavega We should discuss what the appropriate outputs to be displayed at each level, and what are the appropriate ones to pass to the next level.

Currently, we are displaying and passing effect_maps at the first level, and then stat_maps at all levels higher. I'm guessing this was done for 2-level models, and what we may actually want are effect_maps at all but the final level, and then stat_maps at the final level.

But a thing to note: nistats doesn't permit using effects and variances to perform second-level models; you just get one map and you run an intercept. I believe @bthirion said he uses z-score maps for this reason, but it's not clear to me that this is equivalent.

@bthirion
Copy link

No, this is not equivalent. I'm actually working on adding mixed-effects models with known firs-level variance to nistats. I have a branch with it. Will send a PR tomorrow.

@effigies effigies mentioned this pull request Apr 19, 2019
@adelavega
Copy link
Collaborator

adelavega commented Apr 22, 2019

From what I can tell, this closes #133. I would just suggest renaming the input names of SecondLevelModel effect_maps rather than stat_maps, as that's what's actually going into them now.

@effigies
Copy link
Collaborator Author

@adelavega This works for me on a 3-level model. Do you want to test before I merge, or just go for it?

@effigies effigies changed the title ENH: Produce all output types ENH: Produce all available statistical maps from each analysis unit Apr 30, 2019
@adelavega
Copy link
Collaborator

Looks good from a quick glance, so go ahead and merge and I'll test with the other upcoming changes.

@effigies effigies merged commit cc92030 into poldracklab:master Apr 30, 2019
@effigies effigies deleted the enh/all_outputs branch April 30, 2019 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants