Fix avg & unique by reverting to old cartesian join#8770
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@pieterbeulque Should we discard this? |
|
… well. It's not calculating correctly in production right now, but merging this would be a performance regression. @Yopi - since you "broke" it / fixed the performance issue (half empty / half full kind of way to look at it, haha), what do you think? Not pointing fingers 😊 Actually, not sure how it'd go together with the other optimizations made in main since this PR. |
|
I'm also not sure. Maybe we should merge this just to get it working correctly. Given the other changes we've made it might be fine out of a performance improvement perspective. |
ac3183c to
2a2228b
Compare
|
@Yopi - I rebased this against main so maybe we can merge it now? I think the issue is still in main. |
2a2228b to
19dbba1
Compare
Lets do it |
Just to test. Follow-up to #8769
To be correct, I think we should do something like this, but could run some numbers to assess the impact on performance etc?