Use correct aggregation function for quantities total

[pieterbeulque]

Summary

Fixes a regression in the /v1/meters/{id}/quantities API endpoint where the total field was incorrectly calculated for meters with non-summable aggregations (MAX, MIN).

Bug

Users reported seeing incorrect values in the total field:

When I look in the UI, the events show total_enabled_servers: 1. However, when reading from the API with a 30 day lookback, I see almost every org showing 29/30/31.

For meters with max aggregation, the quantities.total value returns the sum of all values (not max across all values).

Root Cause

This is a regression introduced in commit 668ea64 (Dec 18, 2025) titled "meter: Speed up query by avoiding large cartesian join".

Before the regression

The original code correctly used the meter's aggregation function for the total:

func.coalesce(
    meter.aggregation.get_sql_column(Event).filter(
        interval.sql_date_trunc(Event.timestamp) >= interval.sql_date_trunc(start_timestamp),
        interval.sql_date_trunc(Event.timestamp) <= interval.sql_date_trunc(end_timestamp),
    ),
    0,
).label("total"),

After the regression

Commit 668ea64

The performance optimization refactored the query to use pre-computed daily aggregates, but hardcoded func.sum() for the total:

func.coalesce(
    func.sum(daily_metrics.c.quantity).over(order_by=timestamp_column),
    0,
).label("total"),

This works correctly for summable aggregations (count, sum) but is incorrect for non-summable ones (max, min, avg, unique).

Fix

The fix determines the appropriate SQL window function based on whether the meter's aggregation is summable:

if meter.aggregation.is_summable():
    total_agg_func = func.sum
else:
    total_agg_func = meter.aggregation.func.get_sql_function

This is still broken for average & unique aggregation meters.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments

Project	Deployment	Review	Updated (UTC)
polar	Ignored	Preview	Jan 6, 2026 7:33am
polar-sandbox	Ignored	Preview	Jan 6, 2026 7:33am

[Yopi]

Makes sense, yes