fix(python): Wrap deprecated top-level imports in TYPE_CHECKING#24340
Merged
Conversation
orlp
requested review from
MarcoGorelli,
alexander-beedie,
c-peters,
reswqa and
ritchie46
as code owners
github-actions
Bot
added
fix
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24340 +/- ##
==========================================
- Coverage 81.79% 81.77% -0.03%
==========================================
Files 1680 1680
Lines 227742 227743 +1
Branches 2919 2920 +1
==========================================
- Hits 186291 186235 -56
- Misses 40721 40777 +56
- Partials 730 731 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
orlp
force-pushed
the
getattr-type-checking
branch
from
335b8a6 to
911d414
Compare
MarcoGorelli
approved these changes
Sep 4, 2025
Collaborator
MarcoGorelli
left a comment
MarcoGorelli
left a comment
There was a problem hiding this comment.
nice, i'd say that requiring the extra type: ignore[attr-defined] prove it's working 🙌
nameexhaustion
changed the title
dangotbanned
added a commit
to narwhals-dev/narwhals
that referenced
this pull request
Sep 18, 2025
Related: - pola-rs/polars#24334 - pola-rs/polars#24340 ```py narwhals/_polars/utils.py:107:47 - error: "UInt128" is not a known attribute of module "polars" (reportAttributeAccessIssue) ```
10 tasks
MarcoGorelli
pushed a commit
to narwhals-dev/narwhals
that referenced
this pull request
Oct 3, 2025
* ci(typing): Bump `polars==1.33.1` Related: - pola-rs/polars#24334 - pola-rs/polars#24340 ```py narwhals/_polars/utils.py:107:47 - error: "UInt128" is not a known attribute of module "polars" (reportAttributeAccessIssue) ``` * fix: Remove check for non-existent `polars.UInt128` `polars` only has `pl.Int128` #1570 * fix: Use a self doc condition w/ the right version `1.18.0` instead of `1.8.0` * fix: Partial revert, `pl.UInt128` will soon-exist #3138 (comment) * perf: Move `pl.Int128` branch out of `narwhals_to_native_dtype` * maybe fix coverage? #3138 (comment) * ci(typing): Bump `polars==1.34.0` * fix(typing): Remove ignore fixed by my pr 🥳 pola-rs/polars#24584 * chore: actually integrate `pl.UInt128` #3138 (comment), #3138 (comment)) * style: Sort version guards in reverse-chrono * test: Roundtrip coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24334.