Skip to content

feat: Support polars.UInt128#3138

Merged
MarcoGorelli merged 13 commits into
mainfrom
bump-fix-polars-1-33-1
Oct 3, 2025
Merged

feat: Support polars.UInt128#3138
MarcoGorelli merged 13 commits into
mainfrom
bump-fix-polars-1-33-1

Conversation

@dangotbanned
Copy link
Copy Markdown
Member

@dangotbanned dangotbanned commented Sep 18, 2025 •
edited
Loading

What type of PR is this? (check all applicable)

  • 💾 Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 🔧 Optimization
  • 📝 Documentation
  • ✅ Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

Opened this to fix a typing issue

narwhals/_polars/utils.py:107:47 - error: "UInt128" is not a known attribute of module "polars" (reportAttributeAccessIssue)

stumbled into a new feature instead 😅

@dangotbanned
ci(typing): Bump polars==1.33.1
508dff4 
Related:
- pola-rs/polars#24334
- pola-rs/polars#24340

```py
narwhals/_polars/utils.py:107:47 - error: "UInt128" is not a known attribute of module "polars" (reportAttributeAccessIssue)
```
@dangotbanned dangotbanned added ci fix typing polars Issue is related to polars backend labels Sep 18, 2025
@dangotbanned
Copy link
Copy Markdown
Member Author

dangotbanned commented Sep 18, 2025

JFC - it literally got added yesterday! 🤦‍♂️

dangotbanned
dangotbanned commented Sep 18, 2025
View reviewed changes
Comment thread narwhals/_polars/utils.py Outdated
@dangotbanned dangotbanned marked this pull request as ready for review September 18, 2025 15:34
dangotbanned
dangotbanned commented Sep 18, 2025
View reviewed changes
Comment thread narwhals/_polars/utils.py Outdated
FBruzzesi
FBruzzesi reviewed Sep 19, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@FBruzzesi FBruzzesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dangotbanned - as it's clear for two comments, I would wait until next polars release is out before finalizing the details and merging the changes 😇

Comment thread narwhals/_polars/utils.py Outdated
Comment thread narwhals/_polars/utils.py Outdated
Comment thread narwhals/_polars/utils.py Outdated
dangotbanned added a commit that referenced this pull request Sep 19, 2025
@dangotbanned
chore(typing): pyright ignore pl.UInt128
27846aa 
Split from #3138 (comment)
@dangotbanned dangotbanned mentioned this pull request Sep 19, 2025
Merged
10 tasks
@dangotbanned dangotbanned marked this pull request as draft October 3, 2025 17:40
@dangotbanned dangotbanned changed the title ci(typing): Bump polars==1.33.1 ci(typing): Bump polars==1.34.0 Oct 3, 2025
@dangotbanned dangotbanned added enhancement New feature or request dtypes and removed fix typing labels Oct 3, 2025
@dangotbanned dangotbanned changed the title ci(typing): Bump polars==1.34.0 feat: Support polars.UInt128 Oct 3, 2025
@dangotbanned dangotbanned marked this pull request as ready for review October 3, 2025 18:51
MarcoGorelli
MarcoGorelli approved these changes Oct 3, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@MarcoGorelli MarcoGorelli merged commit f124786 into main Oct 3, 2025
29 of 31 checks passed
@MarcoGorelli MarcoGorelli deleted the bump-fix-polars-1-33-1 branch October 3, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FBruzzesi FBruzzesi FBruzzesi left review comments

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees

No one assigned

Labels

ci dtypes enhancement New feature or request polars Issue is related to polars backend

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dangotbanned @MarcoGorelli @FBruzzesi