fix: DataFrame plot was raising when some extra keywords were passed to encodings (e.g. x=alt.X(a, axis=alt.Axis(labelAngle=30)))

[MarcoGorelli]

closes #18830

cc @dangotbanned in case you have time/interest to take a look

Summary: the solution used in #18625 breaks if some extra options (e.g. sort, axis) are specified to the encode arguments. What I'm proposing is to extract 'shorthand' in such cases, so that the tooltips can keep being shown by default

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.86%. Comparing base (2b4986a) to head (e8b5ffd).
Report is 16 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #18836   +/-   ##
=======================================
  Coverage   79.86%   79.86%           
=======================================
  Files        1518     1518           
  Lines      205610   205641   +31     
  Branches     2893     2894    +1     
=======================================
+ Hits       164202   164236   +34     
+ Misses      40860    40857    -3     
  Partials      548      548           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dangotbanned]

Will try to look at this properly tomorrow @MarcoGorelli

This could be a source of false positives, you may be safer using inspect.getattr_static
https://docs.python.org/3/library/inspect.html#fetching-attributes-statically

[MarcoGorelli]

thanks @dangotbanned !

the value does need returning, so maybe just using getattr directly is fine?

[ritchie46]

Alright, I will already merge to include in todays release. Can be improved upon later ofcourse!