feat(python): Add tooltip by default to charts#18625
Conversation
MarcoGorelli
changed the title
MarcoGorelli
changed the title
github-actions
Bot
added
enhancement
MarcoGorelli
force-pushed
the
add-tooltip
branch
from
ab0ba24 to
0eb39b3
Compare
MarcoGorelli
requested review from
alexander-beedie,
c-peters,
reswqa and
ritchie46
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18625 +/- ##
==========================================
- Coverage 79.94% 79.90% -0.05%
==========================================
Files 1505 1506 +1
Lines 202579 203219 +640
Branches 2873 2887 +14
==========================================
+ Hits 161958 162383 +425
- Misses 40073 40289 +216
+ Partials 548 547 -1 ☔ View full report in Codecov by Sentry. |
| from altair.typing import ChannelColor as Color | ||
| from altair.typing import ChannelOrder as Order | ||
| from altair.typing import ChannelSize as Size | ||
| from altair.typing import ChannelX as X | ||
| from altair.typing import ChannelY as Y | ||
| from altair.typing import EncodeKwds |
There was a problem hiding this comment.
Just linking the context for this change #18609 (comment)
cc'ing @mattijn as this is a possible solution for vega/altair#3582 (comment)
| Column to color bars by. | ||
| tooltip | ||
| Columns to show values of when hovering over bars with pointer. | ||
| **kwargs | ||
| Additional keyword arguments passed to Altair. |
There was a problem hiding this comment.
note that this is a backwards-compatible change, as anyone passing tooltip will still have their code work due to **kwargs
joelostblom
left a comment
joelostblom
left a comment
There was a problem hiding this comment.
I think tooltips by default is convenient and the approach here seems to make sense to me. Just one minor comment.
| def _add_tooltip(chart: alt.Chart) -> alt.Chart: | ||
| chart.mark = {"type": chart.mark, "tooltip": True} | ||
| return chart |
There was a problem hiding this comment.
Are marks guaranteed to be strings here? It seems like they are by default in polars, but I'm flagging just in case you want to do something like this to check that the mark is not a dict (which you might already have seen).
There was a problem hiding this comment.
@joelostblom I'm pretty sure @MarcoGorelli has been peeking at that PR 😉
Maybe I'm being overly cautious here, but I'm not sure we've tested this thoroughly enough for it to be included in polars without any tests yet
There was a problem hiding this comment.
thanks both!
I've reworked this to create tooltip= explicitly, reckon this is more robust / robust-enough?
dangotbanned
left a comment
dangotbanned
left a comment
There was a problem hiding this comment.
thanks both!
I've reworked this to create
tooltip=explicitly, reckon this is more robust / robust-enough?
Yeah this is great d15c672 (#18625)
Thanks @MarcoGorelli
|
Hi, this is causing issues on my side with Schema validation error: try using df.plot.line(x=alt.X("date", axis=alt.Axis(labelAngle=-90), y='price', color='stock') |
5 participants
I think this is quite nice as the plot is then more interactive by default (and something Altair might want to do anyway? vega/altair#3394)
cc @joelostblom fancy taking a look? does this make sense?
Demo (the tooltip appears where I had my pointer):
Separate PR incoming to improve docs