Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add community library link to readme #151

Merged
merged 3 commits into from
Dec 11, 2023
Merged

Add community library link to readme #151

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
50b9e8a
Update README.md
arasan01 Dec 1, 2023
983375f
Update README.md
arasan01 Dec 1, 2023
ec9da2e
Update README.md
arasan01 Dec 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,7 @@ following projects all build on top of Dependencies:

* [Dependencies Additions](https://github.com/tgrapperon/swift-dependencies-additions): A
companion library that provides higher-level dependencies.
* [Dependencies Extras](https://github.com/arasan01/swift-dependencies-extras): Macros that make swift-dependencies more useful
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely open to adding this, but given that we already have swift-dependencies-additions being a library extending swift-dependencies with higher-level dependencies, have you thought about naming the library more specifically related to the macros it offers?

I know renaming a library is a tall order, so no worries if you're happy with the way things are. Just lemme know and I'll merge when you're ready :)

Copy link
Contributor Author

@arasan01 arasan01 Dec 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stephencelis
Thank you for thinking with me about naming to describe this library. We too have taken the opportunity to think about this once more.
It seems appropriate to position this library as a library that makes swift-dependencies more useful when using protocols. Therefore, we will change the name and description to be based on Protocol.
I also wanted to change the URL to reflect this, but considering that this is a bit of work and that the library itself is under my repository county, I compromised and left it as it is.
Thank you for your review!

arasan01 marked this conversation as resolved.
Show resolved Hide resolved

## Alternatives

Expand Down