Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add community library link to readme #151

Merged
merged 3 commits into from
Dec 11, 2023
Merged

Conversation

arasan01
Copy link
Contributor

@arasan01 arasan01 commented Dec 1, 2023

What is the purpose of the PR?

I would like to add a link to the community library we have created.

Why did this work occur?

I am developing with swift-dependencies as a central part of my product. In this process, there was a lot of protocol-oriented development. So I thought Swift Macros could automatically convert this to Struct-based and realize function-by-function processing changes. We believe this will be of great help to projects with similar challenges.

Why create a separate library and then do a PR to add the link? Why not add this feature to this repository?

We believe this will help a great many people, but ideally as a pointfreeco library, this conversion is not even necessary. This is why we are creating it as a community library.

Libraries to be linked in this PR

https://github.com/arasan01/swift-dependencies-extras

README.md Outdated Show resolved Hide resolved
README.md Outdated
@@ -272,6 +272,7 @@ following projects all build on top of Dependencies:

* [Dependencies Additions](https://github.com/tgrapperon/swift-dependencies-additions): A
companion library that provides higher-level dependencies.
* [Dependencies Extras](https://github.com/arasan01/swift-dependencies-extras): Macros that make swift-dependencies more useful
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely open to adding this, but given that we already have swift-dependencies-additions being a library extending swift-dependencies with higher-level dependencies, have you thought about naming the library more specifically related to the macros it offers?

I know renaming a library is a tall order, so no worries if you're happy with the way things are. Just lemme know and I'll merge when you're ready :)

Copy link
Contributor Author

@arasan01 arasan01 Dec 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stephencelis
Thank you for thinking with me about naming to describe this library. We too have taken the opportunity to think about this once more.
It seems appropriate to position this library as a library that makes swift-dependencies more useful when using protocols. Therefore, we will change the name and description to be based on Protocol.
I also wanted to change the URL to reflect this, but considering that this is a bit of work and that the library itself is under my repository county, I compromised and left it as it is.
Thank you for your review!

README.md Outdated Show resolved Hide resolved
Copy link
Member

@mbrandonw mbrandonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arasan01!

@mbrandonw mbrandonw merged commit e2dc5ef into pointfreeco:main Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants