Packit: disable osh-diff-scan#2632
Merged
Merged
Conversation
Doesn't currently work for go packages anyway. Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
Contributor
Author
If you meant to ask why not, that's because no golang support yet in the diff scan tool used, so it's a nop at this point. |
Contributor
|
It was more of a “we might hypothetically lose some test coverage if they added support in the future, but, meh, probably not worth the extra trouble for now, and anyway I should be trusting the experts”. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doesn't currently work for go packages anyway.