Add conditional release-checking system test #2631
Conversation
mtrmac
left a comment
mtrmac
left a comment
There was a problem hiding this comment.
Thanks!
Test implementation LGTM, although we clearly can’t have it enabled on the main branch the way it is now.
Great thanks for taking a look. Yep, was just verifying that it works 😁 |
|
Hey @lsm5 (not sure if you're still the one to ask) - Is there a way in packit or tmt or (buried in Fedora CI somewhere) to have (If it's not obvious, we definitely don't want it set @jnovy Similar question, do you know how to get make this change in CentOS CI? |
cevich
changed the title
|
hey hey @cevich
I think this should work with a conditional setting of RELEASE_TESTING var based on the initiator. enable everywhere that's not packit. Give me a bit for that. I guess it need not block this PR, unless we are very close to a new release.
We now have TMT tests running on CentOS as well, so one change should fix all. But we'll need downstream testing. Also, CentOS Stream doesn't get updates via packit atm, so the change will have to be manually propagated. |
It shouldn't hurt to get it ready ahead of time. My intention is to backport this to all the RHEL release branches and make the envvar change there as well. Then rinse and repeat with Buildah and Podman. |
|
passed: https://artifacts.dev.testing-farm.io/228c9fb6-708e-4cf8-b183-c41990fbc885/ @cevich could you include this change in |
@jnovy need this change in |
|
ignore the osh-diff-scan #2632 |
@mtrmac do you see this still being a problem? |
Unfortunately on a number of occasions, Skopeo has been released officially with a `-dev` suffix in the version number. Assist in catching this mistake at release time by the addition of a simple conditional test. Note that it must be positively enabled by a magic env. var. before executing the system tests. Also (as suggested by @lsm5) update the TMT test to trigger the new condition for future Fedora releases. Signed-off-by: Chris Evich <cevich@redhat.com>
Unfortunately on a number of occasions, Skopeo has been released officially with a `-dev` suffix in the version number. Assist in catching this mistake at release time by the addition of a simple conditional test. Note that it must be positively enabled by a magic env. var. before executing the system tests. Original PR: podman-container-tools#2631 Signed-off-by: Chris Evich <cevich@redhat.com>
Unfortunately on a number of occasions, Skopeo has been released officially with a `-dev` suffix in the version number. Assist in catching this mistake at release time by the addition of a simple conditional test. Note that it must be positively enabled by a magic env. var. before executing the system tests. Original PR: podman-container-tools#2631 Signed-off-by: Chris Evich <cevich@redhat.com>
Unfortunately on a number of occasions, Skopeo has been released officially with a `-dev` suffix in the version number. Assist in catching this mistake at release time by the addition of a simple conditional test. Note that it must be positively enabled by a magic env. var. before executing the system tests. Original PR: podman-container-tools#2631 Signed-off-by: Chris Evich <cevich@redhat.com>
3 participants
Unfortunately on a number of occasions, Skopeo has been released
officially with a
-devsuffix in the version number. Assist incatching this mistake at release time by the addition of a simple
conditional test. Note that it must be positively enabled by a
magic env. var. before executing the system tests.