(Fix) Validate whitelist min/max #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Pull Request Test Coverage Report for Build 1947
💛 - Coveralls |
|
@fernandomg please resolve conflicts |
# Conflicts: # src/utils/validations.js # src/utils/validations.spec.js
|
@vbaranov done |
fvictorio
reviewed
Apr 11, 2018
| @@ -83,7 +83,7 @@ describe('processWhitelist function', () => { | |||
| const cb = jest.fn() | |||
|
|
|||
| // When | |||
| const { called } = processWhitelist(rows, cb) | |||
| const { called } = processWhitelist({ rows, decimals: 3 }, cb) | |||
There was a problem hiding this comment.
Could you add some test cases for ignoring invalid decimals, and invalid min/max combinations?
src/utils/validations.js
Outdated
| isLessOrEqualThan('Should be less or equal than max')(max) | ||
| )(min) | ||
|
|
||
| return listOfErrors ? listOfErrors.shift() : '' |
There was a problem hiding this comment.
Shouldn't this return undefined when there are no errors?
fvictorio
approved these changes
Apr 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #578
This PR depends on changes made in #767.
StepThreeandManagecomponentsCommits made for this PR: