Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Fix) add validation for Whitelist->min/max value #578

Closed
dennis00010011b opened this issue Feb 8, 2018 · 0 comments
Closed

(Fix) add validation for Whitelist->min/max value #578

dennis00010011b opened this issue Feb 8, 2018 · 0 comments
Assignees
@fernandomg
Labels
logical bug Step3-CrowdsaleSetup Validation

Comments

@dennis00010011b
Copy link

Problem

Min, Max value can be negative
Min can be more or equals than Max

If you are reporting a problem with Token Wizard, please include the following information:

Which network did you use? (Mainnet, Kovan, Rinkeby, etc.)

n/a

If you were able to create it, what is the URL of your crowdsale?

n/a

Do you have screenshots showing the problem?

whitelistminmax

Do you see errors in the dev console? If yes, please include a screenshot

To open the dev console in Google Chrome, press F12, or go to View -> Developer -> Developer Tools, and open the Console tab

If you see errors, please right click on them and "Save as..". Zip saved file and attach it to the Issue.

No
@vbaranov vbaranov mentioned this issue Mar 12, 2018
Merged
@ghost ghost assigned fernandomg Mar 15, 2018
@ghost ghost added the in progress label Mar 15, 2018
@ghost ghost added in progress and removed to do labels Apr 6, 2018
fernandomg added a commit that referenced this issue Apr 9, 2018
@fernandomg
Merge branch 'master' into validate-whitelist-min-max-#578
9f6d574
@fernandomg fernandomg mentioned this issue Apr 9, 2018
Merged
fernandomg added a commit that referenced this issue Apr 10, 2018
@fernandomg
Merge branch 'master' into validate-whitelist-min-max-#578
eec87c0 
# Conflicts:
#	src/utils/validations.js
#	src/utils/validations.spec.js
fernandomg added a commit that referenced this issue Apr 10, 2018
@fernandomg
Merge branch 'master' into validate-whitelist-min-max-#578
fb669f5
fernandomg added a commit that referenced this issue Apr 12, 2018
@fernandomg
Merge branch 'master' into validate-whitelist-min-max-#578
ec3f829
fvictorio referenced this issue Apr 12, 2018
Merge pull request #778 from poanetwork/validate-whitelist-min-max-#578
91941fd 
(Fix) Validate whitelist min/max
@ghost ghost removed the awaiting for review label Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fernandomg fernandomg

Labels
logical bug Step3-CrowdsaleSetup Validation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fernandomg @vbaranov @dennis00010011b