(Fix) Add address to whitelist in manage screen #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Pull Request Test Coverage Report for Build 1644
💛 - Coveralls |
fvictorio
suggested changes
Mar 9, 2018
| @@ -152,15 +152,12 @@ export class WhitelistInputBlock extends React.Component { | |||
| /> | |||
| </div> | |||
| </div> | |||
| {whitelistElements && whitelistElements.map(e => | |||
| {whitelist.length > 0 && whitelist.map((item, index) => | |||
There was a problem hiding this comment.
Pretty sure whitelist.length > 0 is not necessary, React will just ignore the resulting empty array.
src/stores/TierStore.js
Outdated
| const currentAddress = curr.addr.toLowerCase() | ||
| const previousAddress = prev.addr.toLowerCase() | ||
|
|
||
| return currentAddress > previousAddress ? -1 : currentAddress === previousAddress ? curr.stored ? 1 : -1 : 1 |
| let whitelist = this.tiers[crowdsaleNum].whitelist.slice() | ||
| whitelist[whitelistNum].deleted = true | ||
| this.setTierProperty(whitelist, 'whitelist', crowdsaleNum) | ||
| const removedItem = this.tiers[crowdsaleNum].whitelist.splice(whitelistNum, 1)[0] |
There was a problem hiding this comment.
done, and added test for the other modified/created methods
fvictorio
approved these changes
Mar 13, 2018
|
@vbaranov conflict resolution done |
|
@vbaranov Can we merge this? |
|
@fvictorio formally yes, but if you could give me some hours, I'll appreciate it. I plan to test it too soon. |
|
Sure, no problem. I just want to merge as many PRs as possible so that I can start working on #536 with less risk. |
vbaranov
approved these changes
Mar 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #596
In this PR
whitelistElementscollection was removed and only useswhitelist.Style was applied for the whitelist elements in the manage screen, so the user can recognize what addresses are being modified, added or untouched.
Things to fix that I found:
minandmaxvalues are not being checked, so a user can enter aminvalue greater thanmax. The tx will fail, but it won't be clear why.