Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Refactor) Consider removing all checks for contract type #536

Closed
fvictorio opened this issue Jan 30, 2018 · 1 comment
Closed

(Refactor) Consider removing all checks for contract type #536

fvictorio opened this issue Jan 30, 2018 · 1 comment
Assignees
Labels

Comments

@fvictorio
Copy link
Contributor

The codebase has several places where it checks the "contract type" selected in step one (I guess crowdsale type would be a better name). But right now only one crowdsale type is supported. Plus, if another type is added in the future, I seriously doubt that having conditionals sprinkled everywhere is going to be the best approach.

So I think all these conditionals only make the code harder to maintain without giving any future benefit. I propose removing them, since 1) it's a fairly low risk change and 2) it's going to significantly increase the readability of the code.

@vbaranov @igorbarinov Thoughts on this?

@vbaranov
Copy link
Collaborator

Yes, let's remove these obsolete conditions

@ghost ghost assigned fvictorio Mar 14, 2018
@ghost ghost added the in progress label Mar 14, 2018
fvictorio pushed a commit that referenced this issue Mar 15, 2018
Conflicts:
src/components/stepFour/index.js
vbaranov referenced this issue Mar 15, 2018
@ghost ghost removed the in progress label Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants