(Feature) UI Improvements in Invest page #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the signature for the `buy()` function in the base Crowdsade contract
mark-antony1
suggested changes
Nov 4, 2017
src/components/invest/index.js
Outdated
| window.scrollTo(0, 0); | ||
| if (this.tokensToInvestOnChange.bind) this.tokensToInvestOnChange = this.tokensToInvestOnChange.bind(this); | ||
| if (this.investToTokens.bind) this.investToTokens = this.investToTokens.bind(this); | ||
| var state = defaultState; | ||
| state.seconds = 0; | ||
| state.loading = true; | ||
| state.pristineTokenInput = true; | ||
| state.investThrough = 'metamask' | ||
| state.web3Available = false; | ||
| state.crowdsaleAddress = ICOConfig.crowdsaleContractURL || getURLParam("addr") |
There was a problem hiding this comment.
Extract lines 21-26 to an object in a constant or util file and use Object.assign to add it to the default state on line 20
src/components/invest/index.js
Outdated
| return | ||
| }; | ||
|
|
||
| const networkID = ICOConfig.networkID?ICOConfig.networkID:getQueryVariable("networkID"); | ||
| const contractType = this.state.contractTypes.whitelistwithcap;// getQueryVariable("contractType"); | ||
| checkNetWorkByID(web3, networkID); | ||
| newState.contractType = contractType; | ||
| newState.web3Available = true; | ||
| newState.investThrough = 'metamask'; |
There was a problem hiding this comment.
extract string to constant
src/components/invest/index.js
Outdated
| <a className="button button_fill" onClick={this.investToTokens}>Invest now</a> | ||
| <div className="invest-through-container"> | ||
| <select value={this.state.investThrough} className="invest-through" onChange={(e) => this.setState({ investThrough: e.target.value })}> | ||
| <option disabled={!this.state.web3Available} value="metamask">Metamask {!this.state.web3Available ? ' (not available)' : null}</option> |
There was a problem hiding this comment.
extract ternary to variable
fvictorio
requested review from
igorbarinov,
fernandomg,
vbaranov and
mark-antony1
|
Let's try to merge this as soon as possible, so that we can work on solving the MobX PR conflicts. I will create issues for all the non-critical stuff that is pending. |
vbaranov
requested changes
Nov 15, 2017
|
|
|
Fixed, thanks. Just curious, to what method corresponds that hash? |
|
|
vbaranov
approved these changes
Nov 15, 2017
fernandomg
approved these changes
Nov 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #199.
This PR builds upon #199 and adds some improvements:
0xa6f2ae3a, that corresponds tobuy()