-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Refactor) Mobx state management #304
Conversation
Update Store Naming and Eject React
(Refactor) Update Home and stepOne
README: Change maxCap for tier from MetaMask
@15chrjef use this package.json for Mobx PR |
@15chrjef you can merge my PR to your branch to make deployment stage of Wizard working |
Mobx deploy methods fixes
Thanks @vbaranov. It works with the crowdsale through Kovan on the Invest and crowdsale page. |
@15chrjef one bug still exists: From the downloaded at step 4 file:
|
Where do you get these errors? What prompts it? |
@15chrjef It is from downloaded file at step 4. Try to download and compare with that from master branch |
Fix Continue button not showing Errors
I looked into this PR and here's what I thing we should do:
I think this PR is very important for improving the codebase, and the longer we wait, the harder it will be to do it. If there's nothing of much higher priority, I'd focus our efforts this week in getting this merge out of the way. |
This is a huge commit that will require significant time dedicated to testing and resolving merge conflicts. It is a work in progress and is planned to be updated often until it is finally merged in.
High Level Changes
More Detailed Changes
Ejected create-react-app for access to babel, which allows us to use decorators.
Babel file was based upon current mobx documentation.
Updated naming convention of all stores. Each store's name should ideally have 'store' within it to draw less confusion when importing stores into components.
I updated the initialized item name and the class itself.
Added an index.js files for all stores, and imported the stores into App.js. Stores are passed into the Provider method of 'mobx-react'.
Added a build_scripts folder that will hold build, start, and test files.
Things to test
Ensure that the ejection from create-react-app will not obstruct our build process.
Check to see that the provider component has access to the stores. This can be easily done through react-devtools, by checking that the props contain an object of stores.