Backport upstream's impl to clear engine signer.#199
Merged
Conversation
Original commit messages: RPC method parity_clearEngineSigner Add RPC method parity_clearEngineSigner Fixes #113 corrected the return type of clear_author review comment responses and a rebase fix removed a spurrious warning moved clear_signer functionality to set_signer Merge clear_author into MinerService::set_author. Add trace logs to Clique::set_signer. Clique: Don't lock signer multiple times.
varasev
approved these changes
Oct 23, 2019
Member
|
Works fine, but there is no Seems all the similar RPC JSON requests don't report anything into the logs. I'd propose to add an parity-ethereum/ethcore/types/src/header.rs Line 323 in b52ac20 Since openethereum#10920 is already merged, let's maybe propose that in a separate upstream's PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original commit messages:
RPC method parity_clearEngineSigner
Add RPC method parity_clearEngineSigner
Fixes #113
corrected the return type of clear_author
review comment responses and a rebase fix
removed a spurrious warning
moved clear_signer functionality to set_signer
Merge clear_author into MinerService::set_author.
Add trace logs to Clique::set_signer.
Clique: Don't lock signer multiple times.