Skip to content

Backport upstream's impl to clear engine signer.#199

Merged
varasev merged 1 commit into
aura-posfrom
afck-set-sig
Oct 23, 2019
Merged

Backport upstream's impl to clear engine signer.#199
varasev merged 1 commit into
aura-posfrom
afck-set-sig

Conversation

@afck
Copy link
Copy Markdown
Collaborator

@afck afck commented Oct 22, 2019

Original commit messages:

RPC method parity_clearEngineSigner

Add RPC method parity_clearEngineSigner
Fixes #113

corrected the return type of clear_author

review comment responses and a rebase fix

removed a spurrious warning

moved clear_signer functionality to set_signer

Merge clear_author into MinerService::set_author.

Add trace logs to Clique::set_signer.

Clique: Don't lock signer multiple times.

Original commit messages:

RPC method parity_clearEngineSigner

Add RPC method parity_clearEngineSigner
Fixes #113

corrected the return type of clear_author

review comment responses and a rebase fix

removed a spurrious warning

moved clear_signer functionality to set_signer

Merge clear_author into MinerService::set_author.

Add trace logs to Clique::set_signer.

Clique: Don't lock signer multiple times.
@afck afck requested review from phahulin and varasev October 22, 2019 08:40
@varasev varasev merged commit 6bc6f15 into aura-pos Oct 23, 2019
@varasev varasev deleted the afck-set-sig branch October 23, 2019 12:43
@varasev
Copy link
Copy Markdown
Member

varasev commented Oct 23, 2019

Works fine, but there is no info message in node's logs about clearing the engine_signer.

Seems all the similar RPC JSON requests don't report anything into the logs. I'd propose to add an info log message to the change_field function:

fn change_field<T>(hash: &mut Option<H256>, field: &mut T, value: T) where T: PartialEq<T> {

Since openethereum#10920 is already merged, let's maybe propose that in a separate upstream's PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add an RPC method to clear the engine signer

3 participants