This repository was archived by the owner on Nov 6, 2020. It is now read-only.
RPC method for clearing the engine signer#10920
Merged
dvdplm merged 8 commits intoOct 9, 2019
Merged
Conversation
|
It looks like @vkomenda signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
jam10o-new
added
A0-pleasereview 🤓
niklasad1
reviewed
Aug 9, 2019
niklasad1
reviewed
Aug 9, 2019
vkomenda
force-pushed
the
poanetwork-clear-engine-signer
branch
from
443825f to
64d6cb5
Compare
Contributor
Author
|
Please review. |
dvdplm
reviewed
Sep 5, 2019
afck
force-pushed
the
poanetwork-clear-engine-signer
branch
from
2851b0d to
74fcb11
Compare
dvdplm
reviewed
Oct 4, 2019
Collaborator
dvdplm
left a comment
dvdplm
left a comment
There was a problem hiding this comment.
Apologies for the late re-review. I think we're real close!
| fn set_author(&self, author: Author); | ||
|
|
||
| /// Clears the engine signer and stops signing. | ||
| fn clear_author(&self); |
Collaborator
There was a problem hiding this comment.
Do you think the same "trick" would work here too? I.e. avoid adding a new trait method and instead change set_author to take an Option<Author> instead?
Contributor
There was a problem hiding this comment.
Done.
I made it a T: Into<Option<Author>>, so that you can pass in just an Author, and we don't have to update all the call sites.
Also, I added *self.signer.write() = None to MinerService::set_author, which seemed like an omission. Or am I misreading this?
Contributor
There was a problem hiding this comment.
(And: Greetings from Solna! 🙂 🇸🇪)
afck
force-pushed
the
poanetwork-clear-engine-signer
branch
from
74fcb11 to
58ddaee
Compare
Collaborator
|
@niklasad1 can you take a look at this as well please? |
niklasad1
reviewed
Oct 8, 2019
niklasad1
reviewed
Oct 8, 2019
niklasad1
approved these changes
Oct 8, 2019
Collaborator
niklasad1
left a comment
niklasad1
left a comment
There was a problem hiding this comment.
LGTM, except the removed log in clique::set_signer
Add RPC method parity_clearEngineSigner Fixes #113
afck
force-pushed
the
poanetwork-clear-engine-signer
branch
from
58ddaee to
869c3b3
Compare
Contributor
|
Another test failure I can't reproduce locally. |
Collaborator
|
@afck Yeah, it's a CI issue. Restarted and it succeeded. |
niklasad1
added
A6-mustntgrumble 💦
afck
force-pushed
the
poanetwork-clear-engine-signer
branch
from
e6715b1 to
2249974
Compare
niklasad1
added
the
B7-releasenotes 📜
afck
pushed a commit
to poanetwork/parity-ethereum
that referenced
this pull request
Oct 22, 2019
Original commit messages: RPC method parity_clearEngineSigner Add RPC method parity_clearEngineSigner Fixes #113 corrected the return type of clear_author review comment responses and a rebase fix removed a spurrious warning moved clear_signer functionality to set_signer Merge clear_author into MinerService::set_author. Add trace logs to Clique::set_signer. Clique: Don't lock signer multiple times.
varasev
pushed a commit
to poanetwork/parity-ethereum
that referenced
this pull request
Oct 23, 2019
Original commit messages: RPC method parity_clearEngineSigner Add RPC method parity_clearEngineSigner Fixes #113 corrected the return type of clear_author review comment responses and a rebase fix removed a spurrious warning moved clear_signer functionality to set_signer Merge clear_author into MinerService::set_author. Add trace logs to Clique::set_signer. Clique: Don't lock signer multiple times.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new RPC method for clearing the engine signer value.
Original PR: poanetwork#114
See also gnosischain/posdao-test-setup#41 (comment)