Use a 2/3 instead of 1/2 majority in Aura.#132
Merged
Conversation
varasev
requested changes
May 7, 2019
varasev
approved these changes
May 8, 2019
Member
There was a problem hiding this comment.
Works fine if we build it in release mode with cargo build --release --features final.
When building with cargo build (in debug mode), there are 6-second blocks because the second validator doesn't produce blocks for some reason. The bug can be seen with https://github.com/varasev/test-block-reward/tree/debug-mode-test
Seems this bug is not related to this modification because it's also observed for the upstream Parity v2.4.5 stable branch. Created an issue there: openethereum#10637
Member
|
@varasev, change directory to |
Member
OK: |
vkomenda
approved these changes
May 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.