Add a 2/3 quorum option to Authority Round. by afck · Pull Request #10909 · openethereum/parity-ethereum

afck · 2019-07-22T13:22:12Z

This prevents the "Attack of the Clones": https://arxiv.org/pdf/1902.10244.pdf

PR for POA's aura-pos branch: poanetwork#132
Original issue: poanetwork#108

parity-cla-bot · 2019-07-22T13:22:15Z

It looks like @afck signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

afck · 2019-07-22T13:33:19Z

cargo audit failed because of memoffset, which is an indirect dependency via crossbeam-epoch: crossbeam-rs/crossbeam#402

afck · 2019-07-25T12:18:34Z

I can't reproduce that test failure locally: cargo test in the rpc directory passes for me.

ordian · 2019-07-25T13:09:29Z

I can't reproduce that test failure locally: cargo test in the rpc directory passes for me.

That's a known issue: #9636, it fails spuriously. The job is restarted.

dvdplm · 2019-08-07T15:33:49Z

+			match self.sign_count.entry(*signer) {
+				Entry::Occupied(mut entry) => {
+					// decrement count for this signer and purge on zero.
+					*entry.get_mut() -= 1;


Maybe I'm paranoid but if we ever call remove_signers() with an Occupied entry that is 0, then this will underflow and the signer will not be removed. Maybe you can do if *entry.get() == 1 before this and remove it if it is (and decrement if it isn't)?

afck · 2019-08-08T07:52:41Z

I addressed both comments, but I'm not sure about them:
Both instances represent serious bugs within this module (engines::authority_round::finality): Whenever remove_signers is called, those signers are expected to be present in the map, with an entry ≥ 1.

dvdplm · 2019-08-13T14:33:23Z

@afck the diff is looking a bit odd here, not sure what might have happened but it seems like a bunch of unrelated commits got added. Makes it a bit hard to review atm, can you take a look at that please?

afck · 2019-08-13T15:03:41Z

Sorry! Fixed now.

ordian

LGTM, just minor grumbles.

dvdplm

The module docs for Aura are a bit… scarce! :)
I think that we should document our preference for running with 2/3 quorum somewhere. Maybe this PR is a good opportunity for that?

dvdplm · 2019-08-15T14:55:10Z

This lgtm; let's wait for @andresilva to give it a once-over and then merge it.

This prevents the "Attack of the Clones": https://arxiv.org/pdf/1902.10244.pdf

afck · 2019-08-20T13:40:33Z

I rebased, and added a few lines to the module documentation.

andresilva

lgtm

andresilva · 2019-08-21T12:46:27Z

Thanks for the PR and sorry for taking so long to review. It was an easy review at this point though. :)

* master: Add a 2/3 quorum option to Authority Round. (#10909) Fix rlp decode for inline trie nodes. (#10980) Private contract migration and offchain state sync (#10748) manual publish jobs for releases, no changes for nightlies (#10977)

…m-ethcore * dp/chore/extract-clique: Configuration map of block reward contract addresses (#10875) Update ethcore/src/snapshot/consensus/mod.rs Add a 2/3 quorum option to Authority Round. (#10909) Missing import Rename supports_warp to snapshot_mode Introduce Snapshotting enum to distinguish the type of snapshots a chain uses Add an EngineType enum to tighten up Engine.name() signers is already a ref Update ethcore/engines/clique/src/lib.rs Update ethcore/engines/ethash/Cargo.toml Update ethcore/engines/basic-authority/Cargo.toml Update ethcore/block-reward/Cargo.toml

…out-ClientIoMessage * dp/chore/extract-spec-from-ethcore: double semi Extract engines to own crates (#10966) Fix import missing import Configuration map of block reward contract addresses (#10875) Update ethcore/src/snapshot/consensus/mod.rs Add a 2/3 quorum option to Authority Round. (#10909) Missing import Rename supports_warp to snapshot_mode Introduce Snapshotting enum to distinguish the type of snapshots a chain uses Add an EngineType enum to tighten up Engine.name() signers is already a ref Update ethcore/engines/clique/src/lib.rs Update ethcore/engines/ethash/Cargo.toml Update ethcore/engines/basic-authority/Cargo.toml Update ethcore/block-reward/Cargo.toml

…1344-add-ChainID-opcode * dp/chore/sort-out-ClientIoMessage: Extract spec to own crate (#10978) EIP 2028: transaction gas lowered from 68 to 16 (#10987) Fix merge problem double semi Extract engines to own crates (#10966) Fix import missing import Configuration map of block reward contract addresses (#10875) Update ethcore/src/snapshot/consensus/mod.rs Add a 2/3 quorum option to Authority Round. (#10909) Missing import Rename supports_warp to snapshot_mode Introduce Snapshotting enum to distinguish the type of snapshots a chain uses Add an EngineType enum to tighten up Engine.name() signers is already a ref Update ethcore/engines/clique/src/lib.rs Update ethcore/engines/ethash/Cargo.toml Update ethcore/engines/basic-authority/Cargo.toml Update ethcore/block-reward/Cargo.toml

jam10o-new added the A0-pleasereview 🤓 Pull request needs code review. label Jul 22, 2019

afck force-pushed the afck-upstream-23quorum branch from 36b7be6 to eb39ac3 Compare July 25, 2019 10:21

dvdplm reviewed Aug 7, 2019

View reviewed changes

dvdplm requested a review from andresilva August 7, 2019 15:51

afck force-pushed the afck-upstream-23quorum branch from 96b01a2 to f9948ee Compare August 13, 2019 15:02

ordian approved these changes Aug 14, 2019

View reviewed changes

Comment thread json/src/spec/authority_round.rs Outdated

Comment thread ethcore/src/engines/authority_round/finality.rs Outdated

ordian added this to the 2.7 milestone Aug 14, 2019

ordian added A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. M4-core ⛓ Core client code / Rust. and removed A0-pleasereview 🤓 Pull request needs code review. labels Aug 14, 2019

afck force-pushed the afck-upstream-23quorum branch from f9948ee to 9fc0a70 Compare August 15, 2019 08:19

ordian added A8-looksgood 🦄 Pull request is reviewed well. and removed A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. labels Aug 15, 2019

dvdplm reviewed Aug 15, 2019

View reviewed changes

afck added 3 commits August 20, 2019 15:33

Add a 2/3 quorum option to Authority Round.

f1d4a19

This prevents the "Attack of the Clones": https://arxiv.org/pdf/1902.10244.pdf

Make RollingFinality::remove_signers more tolerant.

983b3ab

Rename parameter to two_thirds_majority_transition.

275d086

afck force-pushed the afck-upstream-23quorum branch from 9fc0a70 to 275d086 Compare August 20, 2019 13:39

andresilva approved these changes Aug 21, 2019

View reviewed changes

dvdplm merged commit 175051b into openethereum:master Aug 21, 2019

afck deleted the afck-upstream-23quorum branch August 21, 2019 14:03

afck mentioned this pull request Oct 1, 2019

Obsolete warning about even number of validators? (Authority Round) #11107

Closed

LukaszRozmej mentioned this pull request Feb 7, 2020

2/3 quorum NethermindEth/nethermind#1410

Closed

adria0 mentioned this pull request Nov 23, 2020

Backport xDAI support openethereum/openethereum#118

Closed

Conversation

afck commented Jul 22, 2019

Uh oh!

parity-cla-bot commented Jul 22, 2019

Uh oh!

afck commented Jul 22, 2019

Uh oh!

afck commented Jul 25, 2019

Uh oh!

ordian commented Jul 25, 2019

Uh oh!

dvdplm Aug 7, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

afck commented Aug 8, 2019

Uh oh!

dvdplm commented Aug 13, 2019

Uh oh!

afck commented Aug 13, 2019

Uh oh!

ordian left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dvdplm left a comment

Choose a reason for hiding this comment

Uh oh!

dvdplm commented Aug 15, 2019

Uh oh!

afck commented Aug 20, 2019

Uh oh!

andresilva left a comment

Choose a reason for hiding this comment

Uh oh!

andresilva commented Aug 21, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants