Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove legacy signal handlers #5224

Merged
merged 2 commits into from
Aug 17, 2022
Merged

fix: remove legacy signal handlers #5224

merged 2 commits into from
Aug 17, 2022

Conversation

d3lm
Copy link
Contributor

@d3lm d3lm commented Aug 17, 2022

This PR removes legacy signal handlers which are no longer necessary. This also means that when someone runs a script that gets interrupted, the process now properly terminates with the correct status code, e.g. 130 for SIGINT and not always 0.

@d3lm d3lm requested a review from zkochan as a code owner August 17, 2022 09:48
@zkochan zkochan merged commit 71e1208 into main Aug 17, 2022
@zkochan zkochan deleted the fix/remove-signal-handlers branch August 17, 2022 09:58
This was referenced Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants