fix: add useReducedMotion compatibility for Safari 13 and older
#2300
+15
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5fd17bb The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Can you please add a changeset to the PR? 😊 otherwise looks great to me, thanks for the fix! |
|
@joshuaellis |
joshuaellis
previously approved these changes
Jul 8, 2024
joshuaellis
approved these changes
Jul 9, 2024
This was referenced Aug 12, 2024
This was referenced Aug 15, 2024
This was referenced Aug 25, 2024
This was referenced Sep 3, 2024
This was referenced Sep 14, 2024
This was referenced Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Currently, calling
useReducedMotionon a Safari browser older than v14 causes an error, crashing the app.This pull request adds compatibility checks, so that
useReducedMotioncan be called on older devices without producing an error.Resolves #2299
What
Adds truthy checks to
MediaQueryList.addEventListenerbefore attempting to call the function. This function is undefined on older browsers.Checklist