-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Implement Brewing #4413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Implement Brewing #4413
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
025440f
Working brewing
VixikHD 23359e7
Send spawn data
VixikHD 13a0197
Some fixes
VixikHD 576810b
Better documentation
VixikHD cf08647
Seconds -> ticks
VixikHD 086b86e
Some updates
VixikHD a9054df
Use constants for brewing inventory slots
VixikHD 8d0921f
Merge branch 'master' into feature/brewing
VixikHD 4cfcd9a
Fixes
VixikHD 9874f8d
Merge branch 'master' into feature/brewing
dktapps a42ec88
...
dktapps f304840
Fix formatting issues
dktapps 90ab0bd
CraftingDataCache: use ItemTranslator directly
dktapps 67719ed
Remove unnecessary nullsafe operator
dktapps ef48115
Consistently use results terminology
dktapps 0135acb
BrewItemEvent: clone items
dktapps 83ba253
Remove unnecessary check
dktapps c3e1d3b
Moved brewing events to a more appropriate namespace
dktapps d02b081
Merge branch 'next-minor' into feature/brewing
dktapps 8a8642a
fix
dktapps a9f7a2b
don't use deprecated operators
dktapps e46aa1b
documentation improvement
dktapps 453364c
Enforce positive brewing time in events
dktapps 3fd90b4
Fixed block slots not being updated on inventory content change
dktapps 56e08d0
Added missing sound
dktapps c5c9b3f
fuck you PhpStorm
dktapps 19d64ac
improved documentation
dktapps 961e95c
rename const
dktapps 9aec177
Enhance return types of CraftingManager methods
dktapps File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| <?php | ||
|
|
||
| /* | ||
| * | ||
| * ____ _ _ __ __ _ __ __ ____ | ||
| * | _ \ ___ ___| | _____| |_| \/ (_)_ __ ___ | \/ | _ \ | ||
| * | |_) / _ \ / __| |/ / _ \ __| |\/| | | '_ \ / _ \_____| |\/| | |_) | | ||
| * | __/ (_) | (__| < __/ |_| | | | | | | | __/_____| | | | __/ | ||
| * |_| \___/ \___|_|\_\___|\__|_| |_|_|_| |_|\___| |_| |_|_| | ||
| * | ||
| * This program is free software: you can redistribute it and/or modify | ||
| * it under the terms of the GNU Lesser General Public License as published by | ||
| * the Free Software Foundation, either version 3 of the License, or | ||
| * (at your option) any later version. | ||
| * | ||
| * @author PocketMine Team | ||
| * @link http://www.pocketmine.net/ | ||
| * | ||
| * | ||
| */ | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace pocketmine\crafting; | ||
|
|
||
| use pocketmine\item\Item; | ||
|
|
||
| interface BrewingRecipe{ | ||
| public function getResultFor(Item $input) : ?Item; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.