Implement Brewing#4413
Conversation
dktapps
left a comment
There was a problem hiding this comment.
I haven't reviewed this in-depth yet, but it's looking interesting.
dktapps
left a comment
There was a problem hiding this comment.
This looks good so far, but there are a few things that should be addressed.
Also, the formatting is inconsistent in some places - if you use PhpStorm, please reformat your code using the provided Project code style.
dktapps
left a comment
There was a problem hiding this comment.
Please reformat the code using the provided Project code style.
|
I think this is now more or less ready to merge. I will note that the one thing I'm unhappy about is the exposure of legacy item IDs to the API in |
Introduction
This pull request implements basic Brewing stand functionality.
Relevant issues
Changes
API changes
pocketmine\event\inventory\BrewingFuelUseEventandpocketmine\event\inventory\BrewItemEventeventsBrewingStandInventory->getIngredient(): Item,BrewingStandInventory->setIngredient(Item): void,BrewingStandInventory->getFuel(): ItemandBrewingStandInventory->setFuel(Item): voidBehavioural changes
Backwards compatibility
Tests
https://streamable.com/4ma0lh