Skip to content

Implement Brewing#4413

Merged
dktapps merged 29 commits intopmmp:next-minorfrom
VixikHD:feature/brewing
Jan 22, 2022
Merged

Implement Brewing#4413
dktapps merged 29 commits intopmmp:next-minorfrom
VixikHD:feature/brewing

Conversation

@VixikHD
Copy link
Contributor

@VixikHD VixikHD commented Aug 29, 2021

Introduction

This pull request implements basic Brewing stand functionality.

Relevant issues

  • There is no issue related to this pull request

Changes

API changes

  • New pocketmine\event\inventory\BrewingFuelUseEvent and pocketmine\event\inventory\BrewItemEvent events
  • Added methods BrewingStandInventory->getIngredient(): Item, BrewingStandInventory->setIngredient(Item): void, BrewingStandInventory->getFuel(): Item and BrewingStandInventory->setFuel(Item): void

Behavioural changes

  • Brewing stand is now implemented

Backwards compatibility

  • None

Tests

https://streamable.com/4ma0lh

@VixikHD VixikHD marked this pull request as ready for review August 29, 2021 10:33
Copy link
Member

@dktapps dktapps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't reviewed this in-depth yet, but it's looking interesting.

@dktapps dktapps self-requested a review August 29, 2021 11:44
@dktapps dktapps added Category: API Related to the plugin API Category: Gameplay Related to Minecraft gameplay experience Type: Contribution labels Aug 29, 2021
Copy link
Member

@dktapps dktapps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good so far, but there are a few things that should be addressed.
Also, the formatting is inconsistent in some places - if you use PhpStorm, please reformat your code using the provided Project code style.

Copy link
Member

@dktapps dktapps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reformat the code using the provided Project code style.

@VixikHD VixikHD requested a review from dktapps September 13, 2021 14:29
@dktapps dktapps added this to the 4.1 milestone Nov 8, 2021
@dktapps dktapps changed the base branch from master to next-minor December 29, 2021 21:58
@dktapps
Copy link
Member

dktapps commented Jan 22, 2022

I think this is now more or less ready to merge.

I will note that the one thing I'm unhappy about is the exposure of legacy item IDs to the API in PotionContainerChangeRecipe. However, this is a hard problem to solve given currently available API, so I don't consider it a showstopper.

@dktapps dktapps merged commit e0da99a into pmmp:next-minor Jan 22, 2022
@dktapps dktapps added Type: Enhancement Contributes features or other improvements to PocketMine-MP and removed Type: Contribution labels Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Category: API Related to the plugin API Category: Gameplay Related to Minecraft gameplay experience Type: Enhancement Contributes features or other improvements to PocketMine-MP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants